Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs found during TPI #19925

Merged
merged 8 commits into from
Oct 3, 2022
Merged

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Sep 30, 2022

Closes #19889
Closes #19890
Closes #19891
Closes #19894
Closes #19897
Closes #19852
Closes #19851
Closes #19838
Closes #19916
Closes #19917

@karthiknadig karthiknadig added the no-changelog No news entry required label Sep 30, 2022
@karthiknadig karthiknadig self-assigned this Sep 30, 2022
@karthiknadig karthiknadig marked this pull request as ready for review September 30, 2022 22:10
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to verify so many issues with one PR, can you add the next milestone to all these issues so they can be verified? LGTM otherwise.

src/client/interpreter/virtualEnvs/virtualEnvPrompt.ts Outdated Show resolved Hide resolved
src/client/interpreter/virtualEnvs/virtualEnvPrompt.ts Outdated Show resolved Hide resolved
@karrtikr karrtikr changed the title Fix bugs found during TPI. Fix bugs found during TPI Oct 3, 2022
@karrtikr
Copy link

karrtikr commented Oct 3, 2022

Hard to verify so many issues with one PR, can you add the next milestone to all these issues so they can be verified?

I still do not see milestones added for each of closed issues.

@karthiknadig
Copy link
Member Author

We will have to verify these before release. So, I will create a bug-bash for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment