Add nushell support to venv activation #20842

flying-sheep · 2023-03-13T13:27:21Z

Fixes #19359

flying-sheep · 2023-03-13T13:28:16Z

@microsoft-github-policy-service agree

karrtikr

Thanks for the PR!

We do not support detecting Nushell as well, first a support will need to be added here:

vscode-python/src/client/common/terminal/shellDetectors/baseShellDetector.ts

Lines 35 to 47 in 5dac08c

    
           const detectableShells = new Map<TerminalShellType, RegExp>(); 
        
           detectableShells.set(TerminalShellType.powershell, IS_POWERSHELL); 
        
           detectableShells.set(TerminalShellType.gitbash, IS_GITBASH); 
        
           detectableShells.set(TerminalShellType.bash, IS_BASH); 
        
           detectableShells.set(TerminalShellType.wsl, IS_WSL); 
        
           detectableShells.set(TerminalShellType.zsh, IS_ZSH); 
        
           detectableShells.set(TerminalShellType.ksh, IS_KSH); 
        
           detectableShells.set(TerminalShellType.commandPrompt, IS_COMMAND); 
        
           detectableShells.set(TerminalShellType.fish, IS_FISH); 
        
           detectableShells.set(TerminalShellType.tcshell, IS_TCSHELL); 
        
           detectableShells.set(TerminalShellType.cshell, IS_CSHELL); 
        
           detectableShells.set(TerminalShellType.powershellCore, IS_POWERSHELL_CORE); 
        
           detectableShells.set(TerminalShellType.xonsh, IS_XONSH);

Please fix linting and other related failures on CI.
Lastly, please add tests for the corresponding changes.

src/client/common/terminal/environmentActivationProviders/nushell.ts

flying-sheep · 2023-03-14T14:09:43Z

Hi, I’m unsure what to do regarding testing. I guess “just add a unit test” is probably correct, but I didn’t find clear instructions. Maybe this could be improved?

CONTRIBUTING.md links to the wiki main page. It doesn’t have in-text links to anything about contributing or testing, but there’s a sidebar with all wiki pages. Maybe it should mention the right page to go to when trying to contribute?
The wiki page Submitting a pull request doesn’t mention what tests to add. Maybe it should say “Go to the Testing page and add one or more tests that best fit your change”?
The wiki page Testing mentions a lot of options in great detail, but not what exactly to do when creating a PR. Maybe it should do that?
The check output is also not very clear: This “Check for changed files” run says

TypeScript code was edited without also editing a "src//*.test.ts\nsrc//*.testvirtualenvs.ts\n.github/test_plan.md" file; see the Testing page in our wiki on testing guidelines (the "skip tests" label can be used to pass this check)

The file pattern in there implies I should ask a test plan, but from context I assume this means that I should add a unit test (or in case my change wouldn’t be testable, add a test plan document), is that right? Maybe the file pattern should be removed or explained

karrtikr · 2023-03-14T19:04:55Z

Created #20854 on your behalf to help clarify 🙂

karrtikr · 2023-03-14T19:08:41Z

Make sure to install appropriate linters as coding guidelines here suggest: https://github.com/microsoft/vscode-python/wiki/Coding#guidelines

flying-sheep · 2023-03-15T14:00:35Z

OK, sure! I thought it was a false positive at first because the bash.ts file has the same code and doesn’t throw an error, but it just seems like all the other files were just wholesale ignored yikes! I fixed that, hope that’s OK.

karrtikr

Thanks for the changes. It appears we still need to fix some tests and add tests as well.

src/client/common/terminal/environmentActivationProviders/baseActivationProvider.ts

flying-sheep · 2023-03-16T17:01:24Z

Thanks for the changes. It appears we still need to fix some tests and add tests as well.

I’m a bit busy currently, but I’ll get around to it.

flying-sheep · 2023-03-18T14:07:17Z

Hi @DonJayamanne, you implemented the failing test in #3930. Any idea why it fails?

https://github.com/flying-sheep/vscode-python/blob/9f1bc4ab4dc5c89013f6ca2976df826461d14258/src/test/common/terminals/helper.unit.test.ts#L321-L349

flying-sheep · 2023-03-24T12:47:36Z

OK, should all be handled now, except for the check I commented out.

I have no idea what that test does though, so without help I can’t fix that.

check the diff with “ignore whitespace” on, the reformatting otherwise makes it hard to parse what changed: https://github.com/microsoft/vscode-python/pull/20842/files?w=1

karrtikr

Thank you, Great work! I'll look into the skipped test.

Lastly, can you demonstrate via screenshots activation is working for nushell?

src/client/common/terminal/environmentActivationProviders/baseActivationProvider.ts

src/test/common/terminals/activation.bash.unit.test.ts

src/test/common/terminals/helper.unit.test.ts

karrtikr

It's not run for bash as command prompt is prioritized over nushell if it is able to return the command.

src/test/common/terminals/helper.unit.test.ts

Co-authored-by: Kartik Raj <karraj@microsoft.com>

flying-sheep · 2023-03-30T10:02:56Z

Hmm, I don’t know what’s wrong. It doesn’t work and I can’t set breakpoints:

karrtikr

Delete the vscode-python/out directory, and close and reopen all instances of VSCode. The issue should go away.

Lastly, can you demonstrate via screenshots activation is working for nushell?

Then please provide this.

flying-sheep · 2023-03-31T13:13:56Z

Ah, good. It does work!

karrtikr

Perfect, appreciate all the effort.

flying-sheep · 2023-04-03T13:34:59Z

Thank you for walking me through it!

…elease 2023.8.0 of vscode-python Merge pull request #87 from posit-dev/merge-latest-upstream Merge latest upstream after Release 2023.8.0 of vscode-python -------------------- Commit message for posit-dev/positron-python@637f894faff15510d62359bba1889e525530535f: Apply fixes after merging latest upstream -------------------- Commit message for posit-dev/positron-python@1c585aa98956f3e835124d97b9067acb23e04dde: Update yarn.lock -------------------- Commit message for posit-dev/positron-python@87931fc5beffe5d7ffd606de53f9cf64954d88a2: Merge remote-tracking branch 'upstream/main' -------------------- Commit message for microsoft/vscode-python@4112b048919ad97a676dfb0b6de992f06a4c5a99: Add some more coverage to utils functions (microsoft/vscode-python#21026) -------------------- Commit message for microsoft/vscode-python@7dfa63125f02b22b23ea7c805442d4d9974839ca: Add telemetry event when creating environment using button (microsoft/vscode-python#21172) A temporary command to understand the usage of the create environment button. Fixes https://github.com/microsoft/vscode-python/issues/21168 -------------------- Commit message for microsoft/vscode-python@f5eded283e9806d42da9377cc12916ea4b68ac6c: Insert debug configuration function on every quickpick item (microsoft/vscode-python#21165) Now there is no need to modify twice `pickDebugConfiguration` function. Just adding a new `DebugConfigurationQuickPickItem` element would be sufficient Co-authored-by: paulacamargo25 <paulitacv25@gmail.com> -------------------- Commit message for microsoft/vscode-python@24c57bdca2bc0789c902aeede5d14ff4cfe9b939: Fix typo in a type declaration of MultiStepInput module (microsoft/vscode-python#21156) -------------------- Commit message for microsoft/vscode-python@68fc3b1d045848fb66c7ddc068d8fb211370bcc1: Migrate azure pipelines to node 16 (microsoft/vscode-python#21162) -------------------- Commit message for microsoft/vscode-python@73cdbf179fe26d63213d37f6f015f4c35a7798e1: Update extension to node 16 (microsoft/vscode-python#21161) For https://github.com/microsoft/vscode-python/issues/21144 -------------------- Commit message for microsoft/vscode-python@4b5cc8d2cf049974f4ae5799aec4b9802f09df84: Update main to next pre-release version (microsoft/vscode-python#21160) -------------------- Commit message for microsoft/vscode-python@0db657725aa72b4e50db87601d3a015103f2bb17: Release candidate (microsoft/vscode-python#21159) -------------------- Commit message for microsoft/vscode-python@f7479fa30737444432b67b44aa79e5a839b027ed: Show formatter extension install prompt and not the old prompt (microsoft/vscode-python#21138) -------------------- Commit message for microsoft/vscode-python@e0558ce5e73240f10de4d1b8105cefe381f682e5: Revert "Default to `--no-cov` when debugging pytest" (microsoft/vscode-python#21152) Reverts microsoft/vscode-python#21048 Closes https://github.com/microsoft/vscode-python/issues/21146 Related https://github.com/microsoft/vscode-python/issues/19985 -------------------- Commit message for microsoft/vscode-python@7e7206701c85cccbb03ece18e10db0ff191ba12f: Add GDPR classification tag for new event (microsoft/vscode-python#21135) -------------------- Commit message for microsoft/vscode-python@42075761a6462464635f56130eb321416156bbb9: Fix telemetry event when using debug file configuration (microsoft/vscode-python#21118) Co-authored-by: paulacamargo25 <paulitacv25@gmail.com> -------------------- Commit message for microsoft/vscode-python@acc890665e4177cc29cb70ac94c322c7ed85082f: Fix workspaceFolderToken -> workspaceFolder (microsoft/vscode-python#21095) The UI string is currently using the internal variable name (workspaceFolderToken) instead of the one actually used in the file (workspaceFolder). This PR fixes that. -------------------- Commit message for microsoft/vscode-python@1f4bfe99fcd08949df5d737b47ad28aba00a7227: Ensure microvenv is added to path after selection. (microsoft/vscode-python#21132) fixes https://github.com/microsoft/vscode-python/issues/21122 -------------------- Commit message for microsoft/vscode-python@d6269a47000012dfb34b7222c7b62c88fe8dd49a: Add Pytest Logging On Workspace Level (microsoft/vscode-python#21133) works on https://github.com/microsoft/vscode-python/issues/21124 but is only half the solution. -------------------- Commit message for microsoft/vscode-python@60db593a1bd10830d627fae2319380ac1c3099cb: Show message in logs when `distutils` is missing. (microsoft/vscode-python#21125) Fixes https://github.com/microsoft/vscode-python/issues/21120 -------------------- Commit message for microsoft/vscode-python@9f24fbf11f4a676354e7c28d0866ddc088d5a074: Support `pythonTerminalEnvVarActivation` experiment in multiroot workspaces (microsoft/vscode-python#21047) -------------------- Commit message for microsoft/vscode-python@d905cf0555e0032cfe10a2af2b925e686246e30e: Pytest fix execution args (microsoft/vscode-python#21094) fix args for runtest IDs -------------------- Commit message for microsoft/vscode-python@7b4bc291254ce15c8e4f80d0f4e18db7a3a851c0: Overload methods testing rewrite (microsoft/vscode-python#21082) I now overload the method signature for discovery and execution so instead the only place where the new rewrite code needs to be enabled is in the controller where it calls either the old method signature without the`pythonExecFactory` or provides it to use the new code. -------------------- Commit message for microsoft/vscode-python@77c63f163a0f7c2a41e9e2e26fcf5aa0f5df1ae9: Remove Pylance auto-indent experiment code (microsoft/vscode-python#21088) -------------------- Commit message for microsoft/vscode-python@9bb5a4466ea112f4a84c9e4c36e14ffbaaffb7ec: Deprecate python logging level setting (microsoft/vscode-python#21083) Deprecates the logging level setting. The default for logging level from VS Code is Info, so in this PR moved a few items to verbose so that we get the same logging experience. Closes https://github.com/microsoft/vscode-python/issues/20844 -------------------- Commit message for microsoft/vscode-python@05cb25549c7a2ef74e7fd8c542af0eaf3946ba3d: Create environment proposed API (microsoft/vscode-python#21074) -------------------- Commit message for microsoft/vscode-python@a009edbda761ca23c460d4f16eeeabb6a8b00e72: Default to `--no-cov` when debugging pytest (microsoft/vscode-python#21048) Resolve microsoft/vscode-python#19985. -------------------- Commit message for microsoft/vscode-python@d23afe8b20c81c962a5292be1e6deceaa8fc6b4c: Add unittest subtest (microsoft/vscode-python#21081) closes https://github.com/microsoft/vscode-python/issues/21038 also updates the subtests names --------- Co-authored-by: Kartik Raj <karraj@microsoft.com> -------------------- Commit message for microsoft/vscode-python@7ddfd9f346cf8f51ed4dfa3effc910727a03ac66: Add black to `extensions.json` (microsoft/vscode-python#20912) Solves microsoft/vscode-python#20855 -------------------- Commit message for microsoft/vscode-python@d05b83f6c1a222464eb894f6a530fc1912bbbdac: Python test execution simple (microsoft/vscode-python#21053) closes https://github.com/microsoft/vscode-python/issues/20897 closes https://github.com/microsoft/vscode-python/issues/20084 closes https://github.com/microsoft/vscode-python/issues/20081 --------- Co-authored-by: Karthik Nadig <kanadig@microsoft.com> -------------------- Commit message for microsoft/vscode-python@61882f7e78c4bcd9d361cfaa189c87f53ce5325f: Add quick pick hover support to explain conda environment lacking a Python interpreter (microsoft/vscode-python#21073) Closes https://github.com/microsoft/vscode-python/issues/20786 -------------------- Commit message for microsoft/vscode-python@8f8f624710149b50ddaa9e5adc028d318529f073: Direct users to the Jupyter extension when using Run in Interactive window (microsoft/vscode-python#21072) Closes https://github.com/microsoft/vscode-python/issues/20576 -------------------- Commit message for microsoft/vscode-python@48952a3c379ea7a67f84528907e8b2d31be60148: Use new logging API for python extension logger and LS logger (microsoft/vscode-python#21062) In this PR: 1. Changes the python extension logging to use LogOutputChannel 2. Changes the language server logger with LogOutputChannel 3. Test output channel uses OutputChannel as it needs to show test output and not really logging. Also, using logging test output makes it pretty much unreadable. 4. Simplifies logging channel and output channel registration. We need to do this now to make it easier for new test work to integrate with output logging. For microsoft/vscode-python#20844 This still doesn't get rid of the log level setting. -------------------- Commit message for microsoft/vscode-python@ab1eb28dde73e20372777211fb845f026693a140: Attempt to fix pre-release build (microsoft/vscode-python#21071) ![image](https://user-images.githubusercontent.com/13199757/232574996-0b772fb3-59cf-40f1-a9b7-8e356dc83a81.png) -------------------- Commit message for microsoft/vscode-python@ed06e550226ea1ae2c2c11139b02089e0186bf1e: Edited Discovery Logic (microsoft/vscode-python#20631) closes https://github.com/microsoft/vscode-python/issues/20078 and closes https://github.com/microsoft/vscode-python/issues/20085 (which is about the testing work to support this code) This logic now successfully works to discover the pytest repo tests. This branch takes into account all the previous comments made to the python discovery logic in the previous PR (located on my personal fork). Therefore this is a second round of edits on this code. It now works for the pytest library (discovers all the tests in the pytest library). --------- Co-authored-by: Brett Cannon <brcan@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> -------------------- Commit message for microsoft/vscode-python@7ac230c8a09f4c9e2c51a207652f5c1fe6f14ab2: Localize walkthroughs (microsoft/vscode-python#21045) Closes https://github.com/microsoft/vscode-python/issues/20906 --------- Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@b68facc42f684f26c5f83f3cfe895e7aa4bb2bee: Remove unused bits entries from package.json (microsoft/vscode-python#21046) -------------------- Commit message for microsoft/vscode-python@586d18f1dcb312612b32f6b30b90492f60e30f30: Fix for missing `pip` in codespaces with `venv` (microsoft/vscode-python#21041) no change logs because this feature is not released yet. Fixes https://github.com/microsoft/vscode-python/issues/21039 -------------------- Commit message for microsoft/vscode-python@b4f0ad1345c4323320a5fe4281affe62ceea8dcc: Expand Testing for Unittest Run in PythonFiles (microsoft/vscode-python#21028) closes https://github.com/microsoft/vscode-python/issues/21031 -------------------- Commit message for microsoft/vscode-python@81debacf1618f3f2aaaf509073064caefc9f4a55: Make fixes to `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21036) For https://github.com/microsoft/vscode-python/issues/20822 -------------------- Commit message for microsoft/vscode-python@7d2cd36d2c4089cc23cd48b7ff7e04e054d39cea: Update packages for Component Governance (microsoft/vscode-python#21037) -------------------- Commit message for microsoft/vscode-python@f058f5efeab5b18e01170f2d76286cfa255b304f: Undo unwanted change in env var tests (microsoft/vscode-python#21035) https://github.com/microsoft/vscode-python/pull/21033#discussion_r1163009663 -------------------- Commit message for microsoft/vscode-python@d61377653e8b6f01c2efebb97ab33860484216e2: Fix debugging when using "internalConsole" (microsoft/vscode-python#21033) Closes https://github.com/microsoft/vscode-python/issues/20828 Do case-insensitive merge of environment variables, always make sure to return the standard env key for an OS, similar to `process.env`. -------------------- Commit message for microsoft/vscode-python@92744f7d52d1c3eb4268177270050917650882a9: Bump xml2js from 0.4.23 to 0.5.0 (microsoft/vscode-python#21032) Bumps [xml2js](https://github.com/Leonidas-from-XIV/node-xml2js) from 0.4.23 to 0.5.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/Leonidas-from-XIV/node-xml2js/commits/0.5.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=xml2js&package-manager=npm_and_yarn&previous-version=0.4.23&new-version=0.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/vscode-python/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@983f05aa34226432191cf8b019668d6d16441184: Add testing for unittest execution python logic (microsoft/vscode-python#21022) these tests cover: - parsing execution args for unittest - test run with no test_ids attached - test run with single test_id and test is a success. --------- Co-authored-by: Karthik Nadig <kanadig@microsoft.com> -------------------- Commit message for microsoft/vscode-python@c64bb0e5403c41b951501f786460fe7b92d65511: Add Testing for PytestExecutionAdapter (microsoft/vscode-python#21019) -------------------- Commit message for microsoft/vscode-python@f4f883c6bf6503ad00c8664ed161ac17fc79e6d4: Fix info needed workflow (microsoft/vscode-python#21021) -------------------- Commit message for microsoft/vscode-python@e288f8b8190b9ec8509c5c69a34bd938172c67ad: Switch to List Data Structure for Checking Known UUIDs in Test Server (microsoft/vscode-python#21018) continue off of the work done related to switching from checking UUIDS in the server file to now doing so in the adapter file. -------------------- Commit message for microsoft/vscode-python@b771c0e91e754cd075ba9acc54daa128870030c6: add tests for unittest execution adapter (microsoft/vscode-python#21017) -------------------- Commit message for microsoft/vscode-python@6fbfde9d200268480794ae9a2c84c179d074b6b8: fix typing to be 3.7 compatible (microsoft/vscode-python#21012) -------------------- Commit message for microsoft/vscode-python@d844f7d2c8951b541d371ecafe0663e3b1a0490f: Bump mheap/github-action-required-labels from 3 to 4 (microsoft/vscode-python#20975) Bumps [mheap/github-action-required-labels](https://github.com/mheap/github-action-required-labels) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mheap/github-action-required-labels/releases">mheap/github-action-required-labels's releases</a>.</em></p> <blockquote> <h2>v4</h2> <p>Tag that always points to the latest commit in the v4.x.x series of releases</p> <h2>v4.0.0</h2> <h2>What's Changed</h2> <ul> <li>Add issues/pull-requests permissions to README by <a href="https://github.com/mheap"><code>@mheap</code></a> in <a href="https://redirect.github.com/mheap/github-action-required-labels/pull/52">mheap/github-action-required-labels#52</a></li> <li>Only use a single comment when the action fails by <a href="https://github.com/mheap"><code>@mheap</code></a> in <a href="https://redirect.github.com/mheap/github-action-required-labels/pull/53">mheap/github-action-required-labels#53</a></li> </ul> <h2>New Contributors</h2> <p><strong>Full Changelog</strong>: <a href="https://github.com/mheap/github-action-required-labels/compare/v3.0.1...v4.0.0">https://github.com/mheap/github-action-required-labels/compare/v3.0.1...v4.0.0</a></p> <h2>v3.0.1</h2> <h2>What's Changed</h2> <ul> <li>Add default error message by <a href="https://github.com/mheap"><code>@mheap</code></a> in <a href="https://redirect.github.com/mheap/github-action-required-labels/pull/51">mheap/github-action-required-labels#51</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/mheap/github-action-required-labels/compare/v3.0.0...v3.0.1">https://github.com/mheap/github-action-required-labels/compare/v3.0.0...v3.0.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mheap/github-action-required-labels/commit/422e4c352ef83db91089e6acfbf09d8725e08abc"><code>422e4c3</code></a> Automatic compilation</li> <li><a href="https://github.com/mheap/github-action-required-labels/commit/e33092117bdd8c435e9b654d53726c6936f19518"><code>e330921</code></a> Only use a single comment when the action fails (<a href="https://redirect.github.com/mheap/github-action-required-labels/issues/53">#53</a>)</li> <li><a href="https://github.com/mheap/github-action-required-labels/commit/9ac12780a2ba3ea157f2abc7f2492db52576e8ab"><code>9ac1278</code></a> Add issues/pull-requests permissions to README</li> <li>See full diff in <a href="https://github.com/mheap/github-action-required-labels/compare/v3...v4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=mheap/github-action-required-labels&package-manager=github_actions&previous-version=3&new-version=4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@869dc64f4734064ccb44011446398e1275647867: switch to using tcp for comm with server (microsoft/vscode-python#20981) code written by @karthiknadig and @eleanorjboyd, which switches to using TCP as the communication channel between the test adapter in the extension and the node server that handles the discovery/running of python tests. --------- Co-authored-by: Karthik Nadig <kanadig@microsoft.com> -------------------- Commit message for microsoft/vscode-python@2401e13f440dc8a36c8ceeff9b231f0c036107f5: Add an automation to close issue with response if Python 2.7 was selected (microsoft/vscode-python#21003) For https://github.com/microsoft/vscode-python/issues/21002 -------------------- Commit message for microsoft/vscode-python@d036567b4fea96dd791b66102a5a9362f52c10b1: Remove not-existent files from .eslintignore (microsoft/vscode-python#21011) Solves microsoft/vscode-python#17181 -------------------- Commit message for microsoft/vscode-python@407717ee4d32bc1ed9e032332210cc49f4142886: Bump peter-evans/create-or-update-comment from 2 to 3 (microsoft/vscode-python#21005) Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peter-evans/create-or-update-comment/releases">peter-evans/create-or-update-comment's releases</a>.</em></p> <blockquote> <h2>Create or Update Comment v3.0.0</h2> <h2>What's new</h2> <ul> <li>Now supports replacing reactions on a comment by setting input <code>reactions-edit-mode</code> to <code>replace</code>. The default behaviour has not changed and will <code>append</code> reactions.</li> <li>Chose how the action should append the comment body with input <code>append-separator</code>. The default behaviour is to add a <code>newline</code>. Other options are <code>space</code> and <code>none</code>.</li> <li><code>body-file</code> is deprecated in favour of <code>body-path</code>. The behaviour is unchanged.</li> </ul> <h2>What's Changed</h2> <ul> <li>v3 by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/161">peter-evans/create-or-update-comment#161</a></li> <li>Update some links in the README by <a href="https://github.com/Kurt-von-Laven"><code>@Kurt-von-Laven</code></a> in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/152">peter-evans/create-or-update-comment#152</a></li> <li>9 dependency updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Kurt-von-Laven"><code>@Kurt-von-Laven</code></a> made their first contribution in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/152">peter-evans/create-or-update-comment#152</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-or-update-comment/compare/v2.1.1...v3.0.0">https://github.com/peter-evans/create-or-update-comment/compare/v2.1.1...v3.0.0</a></p> <h2>Create or Update Comment v2.1.1</h2> <p>⚙️ Fixes the recent Json5 vulnerability.</p> <h2>What's Changed</h2> <ul> <li>11 dependency updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-or-update-comment/compare/v2.1.0...v2.1.1">https://github.com/peter-evans/create-or-update-comment/compare/v2.1.0...v2.1.1</a></p> <h2>Create or Update Comment v2.1.0</h2> <p>⭐ Adds input <code>body-file</code>, the path to a file containing the comment body.</p> <h2>What's Changed</h2> <ul> <li>Replace set-output by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/130">peter-evans/create-or-update-comment#130</a></li> <li>Bump chuhlomin/render-template from 1.5 to 1.6 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/132">peter-evans/create-or-update-comment#132</a></li> <li>Support reading body from a file by <a href="https://github.com/umanghome"><code>@umanghome</code></a> in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/115">peter-evans/create-or-update-comment#115</a></li> <li>Add input body-file by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/133">peter-evans/create-or-update-comment#133</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/umanghome"><code>@umanghome</code></a> made their first contribution in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/115">peter-evans/create-or-update-comment#115</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-or-update-comment/compare/v2.0.1...v2.1.0">https://github.com/peter-evans/create-or-update-comment/compare/v2.0.1...v2.1.0</a></p> <h2>Create or Update Comment v2.0.1</h2> <p>⚙️ Bumps <code>@actions/core</code> to transition away from <a href="https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/">deprecated runner commands</a>.</p> <h2>What's Changed</h2> <ul> <li>Add workflow permissions by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/120">peter-evans/create-or-update-comment#120</a></li> <li>9 dependency updates by <a href="https://github.com/github-actions"><code>@github-actions</code></a> and <a href="https://github.com/dependabot">https://github.com/dependabot</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-or-update-comment/compare/v2.0.0...v2.0.1">https://github.com/peter-evans/create-or-update-comment/compare/v2.0.0...v2.0.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/3383acd359705b10cb1eeef05c0e88c056ea4666"><code>3383acd</code></a> v3 (<a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/161">#161</a>)</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/9c6357680f5ea232e8afaf4efc0cc92367110d78"><code>9c63576</code></a> Bump peter-evans/create-pull-request from 4 to 5 (<a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/163">#163</a>)</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/3d6c0b9c6c6128c3f7fc6f873c0218915585ff51"><code>3d6c0b9</code></a> ci: add missing checkout step</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/1fcda994df6b557d6ae3d3afbd8b4c55bbd14f29"><code>1fcda99</code></a> ci: add test v3 workflow</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/5f728c3dae25f329afbe34ee4d08eef25569d79f"><code>5f728c3</code></a> Bump peter-evans/enable-pull-request-automerge from 2 to 3 (<a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/160">#160</a>)</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/fd9e73cdb111244f59c4bdf94994545011a0d89c"><code>fd9e73c</code></a> Bump eslint from 8.36.0 to 8.37.0 (<a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/159">#159</a>)</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/384c114887453534544cab66743e0ed42a1342a8"><code>384c114</code></a> Bump eslint from 8.35.0 to 8.36.0 (<a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/155">#155</a>)</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/44526e38b60c3be1ea27a6cd6f7359f7ce3f6bc8"><code>44526e3</code></a> Bump jest from 29.4.3 to 29.5.0 (<a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/154">#154</a>)</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/b1fa5d531f73c67e1ab3962d1c16764f188066a6"><code>b1fa5d5</code></a> Bump eslint from 8.34.0 to 8.35.0 (<a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/153">#153</a>)</li> <li><a href="https://github.com/peter-evans/create-or-update-comment/commit/c5a7a9808bb4d6de79278436482399ce9a4de9d5"><code>c5a7a98</code></a> Merge pull request <a href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/152">#152</a> from Kurt-von-Laven/patch-1</li> <li>Additional commits viewable in <a href="https://github.com/peter-evans/create-or-update-comment/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-or-update-comment&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@562ed79db57723d426fed0dcf98163c6c0f43f96: Bump actions/github-script from 4 to 6 (microsoft/vscode-python#21007) Bumps [actions/github-script](https://github.com/actions/github-script) from 4 to 6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/github-script/releases">actions/github-script's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update default runtime to node16 by <a href="https://github.com/thboop"><code>@thboop</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/235">actions/github-script#235</a></li> <li>Update <code>node-fetch</code> by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/237">actions/github-script#237</a></li> <li>Update <code>@actions/core</code> to 1.6.0 by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/238">actions/github-script#238</a></li> </ul> <h3>Breaking Changes</h3> <p>With the update to Node 16 in <a href="https://redirect.github.com/actions/github-script/issues/235">#235</a>, all scripts will now be run with Node 16 rather than Node 12.</p> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/thboop"><code>@thboop</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/235">actions/github-script#235</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v5...v6.0.0">https://github.com/actions/github-script/compare/v5...v6.0.0</a></p> <h2>v5.2.0</h2> <h2>What's Changed</h2> <ul> <li>Upgrade <code>@actions/core</code> to 1.10.0 for v5 by <a href="https://github.com/rentziass"><code>@rentziass</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/350">actions/github-script#350</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v5.1.1...v5.2.0">https://github.com/actions/github-script/compare/v5.1.1...v5.2.0</a></p> <h2>v5.1.1</h2> <h2>What's Changed</h2> <ul> <li>Bump <code>@actions/core</code> to 1.9.1 by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/281">actions/github-script#281</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v5.1.0...v5.1.1">https://github.com/actions/github-script/compare/v5.1.0...v5.1.1</a></p> <h2>v5.1.0</h2> <h2>What's Changed</h2> <ul> <li>Update to latest versions for dev dependencies by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/204">actions/github-script#204</a></li> <li>update plugin dependencies by <a href="https://github.com/PeterNitscheMI"><code>@PeterNitscheMI</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/216">actions/github-script#216</a></li> <li>Update licenses and use <code>jonabc/setup-licensed</code> in workflow by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/228">actions/github-script#228</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/johan-lindqvist"><code>@johan-lindqvist</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/201">actions/github-script#201</a></li> <li><a href="https://github.com/ansgarm"><code>@ansgarm</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/215">actions/github-script#215</a></li> <li><a href="https://github.com/PeterNitscheMI"><code>@PeterNitscheMI</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/216">actions/github-script#216</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v5.0.0...v5.1.0">https://github.com/actions/github-script/compare/v5.0.0...v5.1.0</a></p> <h2>v5.0.0</h2> <h2>What's Changed</h2> <ul> <li>Upgrade to the latest version of Octokit by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/193">actions/github-script#193</a> (Thanks to <a href="https://github.com/IronSean"><code>@IronSean</code></a> for contributing to this fix)</li> </ul> <h2>Breaking Changes</h2> <p>As part of this update, the Octokit context available via <code>github</code> no longer has REST methods directly. These methods are available via <code>github.rest.*</code> - <a href="https://github.com/octokit/plugin-rest-endpoint-methods.js/releases/tag/v5.0.0">https://github.com/octokit/plugin-rest-endpoint-methods.js/releases/tag/v5.0.0</a></p>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/github-script/commit/98814c53be79b1d30f795b907e553d8679345975"><code>98814c5</code></a> Merge pull request <a href="https://redirect.github.com/actions/github-script/issues/339">#339</a> from actions/joshmgross/bump-package-version</li> <li><a href="https://github.com/actions/github-script/commit/ba6cf3fe7cf53f06998ea428adfe8f0da42d62fa"><code>ba6cf3f</code></a> Bump version to 6.4.0</li> <li><a href="https://github.com/actions/github-script/commit/bcc389184da6172665613604320b19b409a8c941"><code>bcc3891</code></a> Merge pull request <a href="https://redirect.github.com/actions/github-script/issues/321">#321</a> from danmichaelo/node-fetch</li> <li><a href="https://github.com/actions/github-script/commit/da8818015eb5c3d01f8ad6db6bd8e3a2b460c71c"><code>da88180</code></a> Merge <code>main</code></li> <li><a href="https://github.com/actions/github-script/commit/4d93f388900dddc32a5a278a0ff985a0f06ca5c8"><code>4d93f38</code></a> Update dist and audit deps</li> <li><a href="https://github.com/actions/github-script/commit/0550e858012a6d3a73fbdd735e96b8e4c35e5a9d"><code>0550e85</code></a> Merge pull request <a href="https://redirect.github.com/actions/github-script/issues/336">#336</a> from actions/joshmgross/minimatch-license</li> <li><a href="https://github.com/actions/github-script/commit/5420835fff8001a224a310d320b6e02eed0713d8"><code>5420835</code></a> Merge branch 'main' into joshmgross/minimatch-license</li> <li><a href="https://github.com/actions/github-script/commit/03377835c3717d8126c1d93eaaa72b55287f783d"><code>0337783</code></a> Merge pull request <a href="https://redirect.github.com/actions/github-script/issues/338">#338</a> from actions/joshmgross/fix-dist</li> <li><a href="https://github.com/actions/github-script/commit/8c6dda0186c7ac8a53030e285851d54aabcd3620"><code>8c6dda0</code></a> Regenerate <code>dist</code></li> <li><a href="https://github.com/actions/github-script/commit/ee0d992b062bc63a761e39c472f63aa0865b1e41"><code>ee0d992</code></a> Use Node 16 in CI and examples</li> <li>Additional commits viewable in <a href="https://github.com/actions/github-script/compare/v4...v6">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/github-script&package-manager=github_actions&previous-version=4&new-version=6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@e1b74f97e73eaa44f8482ffbfb359f15c87a9b4f: Bump actions/checkout from 2 to 3 (microsoft/vscode-python#21006) Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li>Updated to the node16 runtime by default <ul> <li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0">Actions Runner</a> version of v2.285.0 to run, which is by default available in GHES 3.4 or later.</li> </ul> </li> </ul> <h2>v2.7.0</h2> <h2>What's Changed</h2> <ul> <li>Add new public key for known_hosts (<a href="https://redirect.github.com/actions/checkout/issues/1237">#1237</a>) by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1238">actions/checkout#1238</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2.6.0...v2.7.0">https://github.com/actions/checkout/compare/v2.6.0...v2.7.0</a></p> <h2>v2.6.0</h2> <h2>What's Changed</h2> <ul> <li>Add backports to v2 branch by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1040">actions/checkout#1040</a> <ul> <li>Includes backports from the following changes: <a href="https://redirect.github.com/actions/checkout/pull/964">actions/checkout#964</a>, <a href="https://redirect.github.com/actions/checkout/pull/1002">actions/checkout#1002</a>, <a href="https://redirect.github.com/actions/checkout/pull/1029">actions/checkout#1029</a></li> <li>Upgraded the licensed version to match what is used in v3.</li> </ul> </li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2.5.0...v2.6.0">https://github.com/actions/checkout/compare/v2.5.0...v2.6.0</a></p> <h2>v2.5.0</h2> <h2>What's Changed</h2> <ul> <li>Update <code>@actions/core</code> to 1.10.0 by <a href="https://github.com/rentziass"><code>@rentziass</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/962">actions/checkout#962</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2...v2.5.0">https://github.com/actions/checkout/compare/v2...v2.5.0</a></p> <h2>v2.4.2</h2> <h2>What's Changed</h2> <ul> <li>Add set-safe-directory input to allow customers to take control. (<a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>) by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/776">actions/checkout#776</a></li> <li>Prepare changelog for v2.4.2. by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/778">actions/checkout#778</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2...v2.4.2">https://github.com/actions/checkout/compare/v2...v2.4.2</a></p> <h2>v2.4.1</h2> <ul> <li>Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></li> </ul> <h2>v2.4.0</h2> <ul> <li>Convert SSH URLs like <code>org-<ORG_ID>@github.com:</code> to <code>https://github.com/</code> - <a href="https://redirect.github.com/actions/checkout/pull/621">pr</a></li> </ul> <h2>v2.3.5</h2> <p>Update dependencies</p> <h2>v2.3.4</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/379">Add missing <code>await</code>s</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/360">Swap to Environment Files</a></li> </ul> <h2>v2.3.3</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/345">Remove Unneeded commit information from build logs</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/326">Add Licensed to verify third party dependencies</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v3.4.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@actions/io</code></a></li> </ul> <h2>v3.3.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li> <li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li> </ul> <h2>v3.2.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@actions/io</code> to 1.1.2</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li> </ul> <h2>v3.1.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@actions/core</code> <code>saveState</code> and <code>getState</code></a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li> </ul> <h2>v3.0.2</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li> </ul> <h2>v3.0.1</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/762">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/744">Bumped various npm package versions</a></li> </ul> <h2>v3.0.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/689">Update to node 16</a></li> </ul> <h2>v2.3.1</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></li> </ul> <h2>v2.3.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/278">Fallback to the default branch</a></li> </ul> <h2>v2.2.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></li> </ul> <h2>v2.1.1</h2> <ul> <li>Changes to support GHES (<a href="https://redirect.github.com/actions/checkout/pull/236">here</a> and <a href="https://redirect.github.com/actions/checkout/pull/248">here</a>)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/checkout/commit/8f4b7f84864484a7bf31766abe9204da3cbe65b3"><code>8f4b7f8</code></a> Add new public key for known_hosts (<a href="https://redirect.github.com/actions/checkout/issues/1237">#1237</a>)</li> <li><a href="https://github.com/actions/checkout/commit/cd6a9fd49371476d813e892956e2e920fcc3fb7e"><code>cd6a9fd</code></a> Update update-main-version.yml</li> <li><a href="https://github.com/actions/checkout/commit/24cb9080177205b6e8c946b17badbe402adc938f"><code>24cb908</code></a> Bump <code>@actions/io</code> to v1.1.3 (<a href="https://redirect.github.com/actions/checkout/issues/1225">#1225</a>)</li> <li><a href="https://github.com/actions/checkout/commit/27135e314dd1818f797af1db9dae03a9f045786b"><code>27135e3</code></a> Upgrade dependencies (<a href="https://redirect.github.com/actions/checkout/issues/1210">#1210</a>)</li> <li><a href="https://github.com/actions/checkout/commit/7b187184d12a8f064f797aeb51e4873c109637c7"><code>7b18718</code></a> Upgrade codeql actions to v2 (<a href="https://redirect.github.com/actions/checkout/issues/1209">#1209</a>)</li> <li><a href="https://github.com/actions/checkout/commit/ac593985615ec2ede58e132d2e21d2b1cbd6127c"><code>ac59398</code></a> Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>) (<a href="https://redirect.github.com/actions/checkout/issues/1057">#1057</a>)</li> <li><a href="https://github.com/actions/checkout/commit/3ba5ee6fac7e0e30e2ea884e236f282d3a775891"><code>3ba5ee6</code></a> Add in explicit reference to private checkout options (<a href="https://redirect.github.com/actions/checkout/issues/1050">#1050</a>)</li> <li><a href="https://github.com/actions/checkout/commit/885641592076c27bfb56c028cd5612cdad63e16d"><code>8856415</code></a> Implement branch list using callbacks from exec function (<a href="https://redirect.github.com/actions/checkout/issues/1045">#1045</a>)</li> <li><a href="https://github.com/actions/checkout/commit/755da8c3cf115ac066823e79a1e1788f8940201b"><code>755da8c</code></a> 3.2.0 (<a href="https://redirect.github.com/actions/checkout/issues/1039">#1039</a>)</li> <li><a href="https://github.com/actions/checkout/commit/26d48e8ea150211a9bc3b1f0c20448599687d926"><code>26d48e8</code></a> Update <code>@actions/io</code> to 1.1.2 (<a href="https://redirect.github.com/actions/checkout/issues/1029">#1029</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/checkout/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@51d7963f796d9f010873764d6389a75c0a4e5201: Update to latest `debugpy` version 1.6.7 (microsoft/vscode-python#21001) -------------------- Commit message for microsoft/vscode-python@7241760247d1a9a3134fe3d8e2913b5073b80c25: Add `microvenv` support for non-windows platforms (microsoft/vscode-python#20985) This PR contains: 1. `microvenv` fallback if `venv` is not available (implemented in python with tests) 2. Updates to telemetry to include microvenv. Closes https://github.com/microsoft/vscode-python/issues/20905 -------------------- Commit message for microsoft/vscode-python@3c84470185edde5f16122b7462dd096b27b6fb8c: Fix UUID unittest (microsoft/vscode-python#20996) UUID is now handled by the adapter therefore is added to options sent to the server from the adapter. Since the UUID is no longer being added by the server, the server tests should no longer test if the server is correctly handling the UUID. This logic is now passed to the adapter and therefore tests related to processing non-existent UUID and UUID not currently active is the adapters role. -------------------- Commit message for microsoft/vscode-python@22ba6bd9243927d7e0eded835be1ddcb73d4fb28: Don't show create env in diff editor (microsoft/vscode-python#20998) For https://github.com/microsoft/vscode-python/issues/20992 -------------------- Commit message for microsoft/vscode-python@e97e237d52f3b18527134415dbde4884164c0893: Automatically add and remove the "info needed" label (microsoft/vscode-python#20970) Closes https://github.com/microsoft/vscode-python/issues/20944 -------------------- Commit message for microsoft/vscode-python@d637d92d018667a071d46404c05e9afafeaa95a9: Switch to UUID from CWD for testing (microsoft/vscode-python#20980) switches to using the UUID of the discover/run call for unittest and pytest instead of the CWD. This allows for multiple calls from single workspace to be handled. -------------------- Commit message for microsoft/vscode-python@1840a1550e265f8761f959dd5276737308e36d26: Move 'Run in ...' commands to sub-menu (microsoft/vscode-python#20965) Closes https://github.com/microsoft/vscode-python/issues/14350 ![image](https://user-images.githubusercontent.com/3840081/229255829-5ede6390-4411-4636-889b-d1a1d4b4360e.png) -------------------- Commit message for microsoft/vscode-python@6fec579d9df4abcc1bd156d091f73071197ad06b: Auto add community feedback comment (microsoft/vscode-python#20956) Closes https://github.com/microsoft/vscode-python/issues/20943 -------------------- Commit message for microsoft/vscode-python@5528e0efb9b8c91c83dfb356391085280fb63417: Add nushell support to venv activation (microsoft/vscode-python#20842) Fixes microsoft/vscode-python#19359 --------- Co-authored-by: Kartik Raj <karraj@microsoft.com> -------------------- Commit message for microsoft/vscode-python@56d1912407a7e072442de73a9f199ebb0e1b9b04: Fix running Untitled files with the play button (microsoft/vscode-python#20955) Lead-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> Co-authored-by: Aidos Kanapyanov <65722512+aidoskanapyanov@users.noreply.github.com> Co-authored-by: Erik De Bonte <erikd@microsoft.com> Co-authored-by: Philipp A <flying-sheep@web.de> Co-authored-by: Pamela Fox <pamela.fox@gmail.com> Co-authored-by: Tomer Chachamu <tomer.chachamu@gmail.com> Co-authored-by: Pete Farland <pete.farland@posit.co> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carlos Piña Martinez <carlospinamartinezdm@gmail.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com> Signed-off-by: GitHub <noreply@github.com>

Add nushell support to venv activation

72f874c

karthiknadig assigned karrtikr Mar 13, 2023

karthiknadig requested a review from karrtikr March 13, 2023 17:46

karthiknadig added the feature-request Request for new features or functionality label Mar 13, 2023

karrtikr suggested changes Mar 13, 2023

View reviewed changes

src/client/common/terminal/environmentActivationProviders/nushell.ts Outdated Show resolved Hide resolved

flying-sheep added 2 commits March 14, 2023 14:50

add nu shell detector

1115b70

Simplify ActivationScripts type

8f3aab0

flying-sheep added 2 commits March 14, 2023 15:13

Add mock nushell activation providers to tests

71117df

add nushell to tests

d00309d

karrtikr mentioned this pull request Mar 14, 2023

Clarify/Improve instructions related to testing when contributing a pull request #20854

Open

Fix lints

9f1bc4a

karrtikr reviewed Mar 15, 2023

View reviewed changes

src/client/common/terminal/environmentActivationProviders/baseActivationProvider.ts Show resolved Hide resolved

Install nushell in all test helpers

0e0b72b

flying-sheep added 3 commits March 22, 2023 17:40

fix tests with TODO

9e614df

Add test and fix command

90f122e

Merge branch 'main' into nushell-venv

c4728da

flying-sheep requested a review from karrtikr March 24, 2023 12:48

karrtikr reviewed Mar 29, 2023

View reviewed changes

src/client/common/terminal/environmentActivationProviders/baseActivationProvider.ts Show resolved Hide resolved

src/test/common/terminals/activation.bash.unit.test.ts Show resolved Hide resolved

src/test/common/terminals/helper.unit.test.ts Outdated Show resolved Hide resolved

karrtikr changed the title ~~Add nushell support to venv activation~~ Add nushell support for venv activation Mar 29, 2023

karrtikr changed the title ~~Add nushell support for venv activation~~ Add nushell support to venv activation Mar 29, 2023

karrtikr reviewed Mar 29, 2023

View reviewed changes

src/test/common/terminals/helper.unit.test.ts Outdated Show resolved Hide resolved

Fix helper test

2b371b3

Co-authored-by: Kartik Raj <karraj@microsoft.com>

karrtikr reviewed Mar 30, 2023

View reviewed changes

karrtikr approved these changes Mar 31, 2023

View reviewed changes

Tyriar approved these changes Mar 31, 2023

View reviewed changes

karrtikr merged commit 5528e0e into microsoft:main Mar 31, 2023

flying-sheep deleted the nushell-venv branch April 3, 2023 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nushell support to venv activation #20842

Add nushell support to venv activation #20842

flying-sheep commented Mar 13, 2023

flying-sheep commented Mar 13, 2023

karrtikr left a comment •

edited

Loading

flying-sheep commented Mar 14, 2023

karrtikr commented Mar 14, 2023

karrtikr commented Mar 14, 2023

flying-sheep commented Mar 15, 2023 •

edited

Loading

karrtikr left a comment

flying-sheep commented Mar 16, 2023

flying-sheep commented Mar 18, 2023

flying-sheep commented Mar 24, 2023 •

edited

Loading

karrtikr left a comment •

edited

Loading

karrtikr left a comment

flying-sheep commented Mar 30, 2023

karrtikr left a comment

flying-sheep commented Mar 31, 2023

karrtikr left a comment

flying-sheep commented Apr 3, 2023

	const detectableShells = new Map<TerminalShellType, RegExp>();
	detectableShells.set(TerminalShellType.powershell, IS_POWERSHELL);
	detectableShells.set(TerminalShellType.gitbash, IS_GITBASH);
	detectableShells.set(TerminalShellType.bash, IS_BASH);
	detectableShells.set(TerminalShellType.wsl, IS_WSL);
	detectableShells.set(TerminalShellType.zsh, IS_ZSH);
	detectableShells.set(TerminalShellType.ksh, IS_KSH);
	detectableShells.set(TerminalShellType.commandPrompt, IS_COMMAND);
	detectableShells.set(TerminalShellType.fish, IS_FISH);
	detectableShells.set(TerminalShellType.tcshell, IS_TCSHELL);
	detectableShells.set(TerminalShellType.cshell, IS_CSHELL);
	detectableShells.set(TerminalShellType.powershellCore, IS_POWERSHELL_CORE);
	detectableShells.set(TerminalShellType.xonsh, IS_XONSH);

Add nushell support to venv activation #20842

Add nushell support to venv activation #20842

Conversation

flying-sheep commented Mar 13, 2023

flying-sheep commented Mar 13, 2023

karrtikr left a comment • edited Loading

Choose a reason for hiding this comment

flying-sheep commented Mar 14, 2023

karrtikr commented Mar 14, 2023

karrtikr commented Mar 14, 2023

flying-sheep commented Mar 15, 2023 • edited Loading

karrtikr left a comment

Choose a reason for hiding this comment

flying-sheep commented Mar 16, 2023

flying-sheep commented Mar 18, 2023

flying-sheep commented Mar 24, 2023 • edited Loading

karrtikr left a comment • edited Loading

Choose a reason for hiding this comment

karrtikr left a comment

Choose a reason for hiding this comment

flying-sheep commented Mar 30, 2023

karrtikr left a comment

Choose a reason for hiding this comment

flying-sheep commented Mar 31, 2023

karrtikr left a comment

Choose a reason for hiding this comment

flying-sheep commented Apr 3, 2023

karrtikr left a comment •

edited

Loading

flying-sheep commented Mar 15, 2023 •

edited

Loading

flying-sheep commented Mar 24, 2023 •

edited

Loading

karrtikr left a comment •

edited

Loading