Add support of Nushell to venv activation

[karthiknadig]

I'm experiencing something similar. With Nushell, a new terminal instance tries to activate the selected venv with
& c:/Users/ehawman/Documents/Programming/Python/PA-FindReplace/.venv/Scripts/Activate.ps1

The correct command here should be
source c:/Users/ehawman/Documents/Programming/Python/PA-FindReplace/.venv/Scripts/activate.nu

Weirdly, when actually using pwsh it truncates the activation command:
sers/ehawman/Documents/Programming/Python/PA-FindReplace/.venv/Scripts/Activate.ps1, causing it to fail.

Do you think this falls under the same umbrella or should I start a new issue?

Originally posted by @ehawman in #19285 (comment)

[ehawman]

@karthiknadig thank you! I was just scouring the issue list to see if a request existed. I vaguely recalled seeing one but I think that was for a different shell.

See #8341 and #8575

It looks like virtualenv creates activation scripts for:

• Bash
• CMD
• Fish
• Nu
• PowerShell
• Python(?)

@karrtikr mentioned using VSCode API to detect shells in this post. Is it possible to expand the scope of this feature request to a general "support all shells supported by virtualenv", and gracefully tell the user that their shell isn't supported if it isn't?

[karthiknadig]

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

[phiresky]

For me (on Linux) it pastes the path of bash activation script (.venv/bin/activate) into nushell but doesn't actually execute it

[brettcannon]

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.

We do encourage people to continue 👍 the first/opening comment as it helps us prioritize our work based on what the community seems to want the most.

[flying-sheep]

Should be pretty easy:

1. Copy the Bash class and rename the copy to Nushell:

   vscode-python/src/client/common/terminal/environmentActivationProviders/bash.ts

   Lines 37 to 51 in 3698950

   	@injectable()
   	export class Bash extends VenvBaseActivationCommandProvider {
   	protected readonly scripts = SCRIPTS;
   	public async getActivationCommandsForInterpreter(
   	pythonPath: string,
   	targetShell: TerminalShellType
   	): Promise<string[] | undefined> {
   	const scriptFile = await this.findScriptFile(pythonPath, targetShell);
   	if (!scriptFile) {
   	return;
   	}
   	return [`source ${scriptFile.fileToCommandArgument()}`];
   	}
   	}

2. modify it to find the file activate.nu
3. make it return [`overlay activate ${scriptFile.fileToCommandArgument()}`]
4. inject a private readonly nushell like here:

   vscode-python/src/client/common/terminal/helper.ts

   Lines 37 to 39 in 3698950

   	@inject(ITerminalActivationCommandProvider)
   	@named(TerminalActivationProviders.bashCShellFish)
   	private readonly bashCShellFish: ITerminalActivationCommandProvider,

   and add it to this list:

   vscode-python/src/client/common/terminal/helper.ts

   Line 74 in 3698950

   const providers = [this.pipenv, this.pyenv, this.bashCShellFish, this.commandPromptAndPowerShell];

[karrtikr]

FYI we do not support detecting Nushell as well, so in addition to the above a support will need to be added here:

vscode-python/src/client/common/terminal/shellDetectors/baseShellDetector.ts

Lines 35 to 47 in 5dac08c

	const detectableShells = new Map<TerminalShellType, RegExp>();
	detectableShells.set(TerminalShellType.powershell, IS_POWERSHELL);
	detectableShells.set(TerminalShellType.gitbash, IS_GITBASH);
	detectableShells.set(TerminalShellType.bash, IS_BASH);
	detectableShells.set(TerminalShellType.wsl, IS_WSL);
	detectableShells.set(TerminalShellType.zsh, IS_ZSH);
	detectableShells.set(TerminalShellType.ksh, IS_KSH);
	detectableShells.set(TerminalShellType.commandPrompt, IS_COMMAND);
	detectableShells.set(TerminalShellType.fish, IS_FISH);
	detectableShells.set(TerminalShellType.tcshell, IS_TCSHELL);
	detectableShells.set(TerminalShellType.cshell, IS_CSHELL);
	detectableShells.set(TerminalShellType.powershellCore, IS_POWERSHELL_CORE);
	detectableShells.set(TerminalShellType.xonsh, IS_XONSH);

[karrtikr]

Fix should be out in the pre-release version of the extension in a day, use the following to try it out:

[flying-sheep]

Great! I did that, opened a Python project, and it worked!