Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow codes like ABC123 for flake8 v3 plugins #4443

Closed
wants to merge 2 commits into from
Closed

Allow codes like ABC123 for flake8 v3 plugins #4443

wants to merge 2 commits into from

Conversation

peterjc
Copy link

@peterjc peterjc commented Feb 19, 2019

Quoting the flake8 plugin author instructions:

"Please Note: Your entry point does not need to be exactly 4 characters as of Flake8 3.0. Consider using an entry point with 3 letters followed by 3 numbers (i.e. ABC123 )."

http://flake8.pycqa.org/en/latest/plugin-development/registering-plugins.html

This change was in last part motivated by the increasing number of error code collisions with flake8 plugins using the original one letter and three numbers pattern.

This regular expression fix was suggested by @jraygauthier on issue #4074.

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Quoting the flake8 plugin author instructions:

"Please Note: Your entry point does not need to be exactly 4 characters as of Flake8 3.0. Consider using an entry point with 3 letters followed by 3 numbers (i.e. ABC123 )."

http://flake8.pycqa.org/en/latest/plugin-development/registering-plugins.html

This change was in last part motivated by the increasing number of error code collisions with flake8 plugins using the original one letter and three numbers pattern.

This regular expression fix was suggested by @jraygauthier on issue #4074.
@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ peterjc sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@peterjc
Copy link
Author

peterjc commented Feb 19, 2019

I don't think I can sign the CLA given any copyright etc from this change belongs to @jraygauthier

@peterjc peterjc closed this Feb 19, 2019
@peterjc peterjc deleted the patch-1 branch February 19, 2019 16:21
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #4443 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4443   +/-   ##
======================================
  Coverage      57%     57%           
======================================
  Files         364     364           
  Lines       15501   15501           
  Branches     2410    2410           
======================================
  Hits         8757    8757           
  Misses       6163    6163           
  Partials      581     581

@jraygauthier
Copy link

@peterjc thanks for the PR. This is a minor change, I abandon any copyright (if any) on this change.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants