Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt insiders users into beta language server by default #7174

Merged
merged 3 commits into from
Sep 4, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Sep 3, 2019

For #7108

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #7174 into master will decrease coverage by 0.01%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7174      +/-   ##
==========================================
- Coverage    58.5%   58.48%   -0.02%     
==========================================
  Files         485      485              
  Lines       21446    21448       +2     
  Branches     3462     3463       +1     
==========================================
- Hits        12546    12543       -3     
- Misses       8122     8129       +7     
+ Partials      778      776       -2
Impacted Files Coverage Δ
...ion/languageServer/languageServerPackageService.ts 92.59% <92.59%> (+11.82%) ⬆️
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83185a6...9e5390c. Read the comment docs.

Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, other than that looks good 👍

@karrtikr karrtikr merged commit 64fa8a3 into microsoft:master Sep 4, 2019
@karrtikr karrtikr deleted the beta branch September 4, 2019 00:10
@lock lock bot locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants