Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure sorting imports in a modified file picks up the proper configuration #9128
Ensure sorting imports in a modified file picks up the proper configuration #9128
Changes from 6 commits
87155c6
9483205
5a97a63
5a84390
9c8614d
d16466e
62cdfda
ef5066b
bfc21b1
2254599
4720c36
784f9d5
b7aa5ae
6cea1ed
d92ceef
fc34f9c
b5528ee
1c8a392
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a thought about this while writing the docs for it -- should we have this do an explicit
null
orundefined
check, rather than this implicit one? I'm assuming that (like in Python) this implicit check will be falsey for bothnull
and empty string, yet the latter might end up being surprising to callers if they've explicitly provided a value which happens to be empty.