Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history
commit 9442a7e
Author: JiglioNero <43934531+JiglioNero@users.noreply.github.com>
Date:   Tue Jun 9 11:32:53 2020 +0300

    Remove skip from Hermes RN app Debug test (#1307)

    * remove skip from Hermes RN app Debug test

    * check output and fix assert

    * change log file for check result
  • Loading branch information
SounD120 committed Jun 9, 2020
1 parent 0edda03 commit 60b3212
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions test/smoke/package/src/debugAndroid.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ const ExpoSetBreakpointOnLine = 1;
const debugAndroidTestTime = SmokeTestsConstants.androidAppBuildAndInstallTimeout + 100 * 1000;
// Time for Android Expo Debug Test before it reaches timeout
const debugExpoTestTime = SmokeTestsConstants.expoAppBuildAndInstallTimeout + 400 * 1000;
// need for avoid tslint error while skip Hermes test
let skipHermesTest = true;

export function setup(testParameters?: TestRunArguments) {

Expand Down Expand Up @@ -152,9 +150,6 @@ export function setup(testParameters?: TestRunArguments) {
});

it("Hermes RN app Debug test", async function () {
if (skipHermesTest) {
this.skip();
}
this.timeout(debugAndroidTestTime);
prepareReactNativeProjectForHermesTesting();
AndroidEmulatorHelper.uninstallTestAppFromEmulator(RN_APP_PACKAGE_NAME);
Expand Down Expand Up @@ -190,7 +185,7 @@ export function setup(testParameters?: TestRunArguments) {
await sleep(SmokeTestsConstants.debugConsoleSearchTimeout);
if (process.env.REACT_NATIVE_TOOLS_LOGS_DIR) {
console.log("Android Debug Hermes test: Searching for \"Test output from Hermes debuggee\" string in output file");
let found = findStringInFile(path.join(process.env.REACT_NATIVE_TOOLS_LOGS_DIR, SmokeTestsConstants.ChromeDebugCoreLogFileName), "Test output from Hermes debuggee");
let found = findStringInFile(path.join(process.env.REACT_NATIVE_TOOLS_LOGS_DIR, SmokeTestsConstants.ReactNativeLogFileName), "Test output from Hermes debuggee");
assert.notStrictEqual(found, false, "\"Test output from Hermes debuggee\" string is missing in output file");
console.log("Android Debug test: \"Test output from Hermes debuggee\" string is found");
}
Expand Down

0 comments on commit 60b3212

Please sign in to comment.