transfer launch params (env and envFIle) to packager #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add runOption setter to packager for transer launch params
|
|
|
|
…tter to packager for transer launch params change args for getEnvArguments and create tests to getEnvArguments
RedMickey
reviewed
Apr 6, 2020
RedMickey
reviewed
Apr 6, 2020
Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>
Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>
SounD120
reviewed
Apr 6, 2020
SounD120
reviewed
Apr 7, 2020
Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>
Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>
Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>
Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>
RedMickey
reviewed
Apr 8, 2020
RedMickey
reviewed
Apr 8, 2020
Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>
Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>
SounD120
approved these changes
Apr 8, 2020
…the `react-native` packager
SounD120
reviewed
Apr 8, 2020
Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>
Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>
and add check and test for file еxistence
SounD120
reviewed
Apr 8, 2020
Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>
RedMickey
reviewed
Apr 9, 2020
Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>
RedMickey
approved these changes
Apr 9, 2020
JiglioNero
added a commit
that referenced
this pull request
May 18, 2020
* Add telemetry for Expo host types (#1204) * Added handling for an iOS device target concrete device (#1207) * Added handling for a iOS device target concrete device using format 'device=<iOS_device_name>' * Update docs * Add expo tests for different Expo network scenarios (#1208) * Refactor Expo tests * Fix dependency vulnerabilities (#1219) * Bump acorn from 6.4.0 to 6.4.1 in /test/smoke/package (#1222) Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.0 to 1.2.2 Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.2) Signed-off-by: dependabot[bot] <support@github.com> * Bump vulnerable dependencies * Bump several dependencies, fix security vulnerabilities (#1224) * Fix use of custom Xcode scheme in iOS project (#1213) * Add unit tests * Prepare for 0.14.2 (#1225) * Fix security vulnerabilities in mkdirp package (#1227) * Fix minimist security vulnerabilities https://npmjs.com/advisories/1179 * Add YAML pipelines for the smoke tests (#1234) * Enhance error message in case of error when projectRoot parameter is missing (#1237) * Add unit tests YAML pipelines (#1241) * Fix YAML master pipeline (#1244) * Bump React Native version up to 0.62.0 in smoke tests (#1240) * Bump RN version up to 0.62.0 * Update Hermes build.gradle * Fix artifacts generation (#1245) * Fix smoke tests for Expo 37 SDK (#1247) * docs: reorganize content of readme.md (#1243) * transfer launch params (env and envFIle) to packager (#1248) * transfer launch params (env and envFIle) to packager add runOption setter to packager for transer launch params * transfer launch params (env and envFIle) to packager add runOption setter to packager for transer launch params change args for getEnvArguments and create tests to getEnvArguments * Update src/common/packager.ts Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com> * Update test/extension/generalMobilePlatform.test.ts Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com> * port and status indicator from packager getters to codestyle * change dir of tmp .env and add able to use standart .env file ro project path * Update test/extension/generalMobilePlatform.test.ts Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru> * Update test/extension/generalMobilePlatform.test.ts Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru> * Update test/extension/generalMobilePlatform.test.ts Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru> * Update test/extension/generalMobilePlatform.test.ts Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru> * Update test/extension/generalMobilePlatform.test.ts Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com> * Update test/extension/generalMobilePlatform.test.ts Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com> * add to readme description of passing custom enviroment variables for the `react-native` packager * Update README.md Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru> * Update README.md Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru> * fix logic for choice source for env vars and add check and test for file еxistence * add some more info to readme * Update README.md Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru> * Update README.md Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com> Co-authored-by: Mikhail Suendukov <mikhail.suendukov@inyar.ru> Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com> Co-authored-by: Yuri Skorokhodov <yurapkr@yandex.ru> Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * Update command palette commands table in documentation (#1250) * Update Expo documentation (#1251) * Prepare for 0.15.0 (#1255) * Migrate unit tests to vscode-test (#1256) * Fix security vulnerabilities (#1253) * Fix vulnerabilities * Fix fonts usage for Expo 37 (#1260) * Fix runOptions check for packager (#1264) * add check run options * remove font fix for expo 37 from changelog * fix getiing of status indicator * fix unit tests in gulpfile * remove extensions tests from ci * fix .ci -remove debugger tests * cleanup * Delete yarn.lock Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antón Molleda <molant@users.noreply.github.com> Co-authored-by: Mikhail Suendukov <mikhail.suendukov@inyar.ru> Co-authored-by: Yuri Skorokhodov <yurapkr@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1235 add runOption setter to packager for transfer launch params
added fallback to
projectRoot/.envfile if noenvorenvFileare provided