Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fonts usage for Expo 37 #1260

Merged
merged 26 commits into from
Apr 29, 2020
Merged

Fix fonts usage for Expo 37 #1260

merged 26 commits into from
Apr 29, 2020

Conversation

JiglioNero
Copy link
Contributor

@JiglioNero JiglioNero commented Apr 22, 2020 •
edited by SounD120
Loading

Fixes #1252

@JiglioNero JiglioNero self-assigned this Apr 22, 2020
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 suggested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@SounD120 SounD120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments on implementation. It is better not to use any if it can be avoided.

RedMickey
RedMickey reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
JiglioNero and others added 2 commits April 24, 2020 10:56
@JiglioNero @RedMickey
Update src/common/packager.ts
295cdbd 
Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>
@JiglioNero
get back type of packager args and add comments
ce9ebf3
JiglioNero
JiglioNero commented Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
JiglioNero and others added 3 commits April 24, 2020 13:23
@JiglioNero
fix docs
9dcddec
@JiglioNero @SounD120
Update src/common/packager.ts
f646520 
Co-Authored-By: Yuri Skorokhodov <v-yuskor@microsoft.com>
@JiglioNero
additional fix doc
b4c16df
JiglioNero
JiglioNero commented Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
@JiglioNero @SounD120
Update src/common/packager.ts
39a9a53 
Co-Authored-By: Yuri Skorokhodov <v-yuskor@microsoft.com>
JiglioNero and others added 2 commits April 24, 2020 13:32
@JiglioNero @SounD120
Update src/common/packager.ts
2454a70 
Co-Authored-By: Yuri Skorokhodov <v-yuskor@microsoft.com>
@JiglioNero @SounD120
Update src/common/packager.ts
cd9a3d4 
Co-Authored-By: Yuri Skorokhodov <v-yuskor@microsoft.com>
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
SounD120
SounD120 reviewed Apr 24, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
@SounD120 SounD120 changed the title Fix fonts usage for expo37 Fix fonts usage for Expo 37 Apr 24, 2020
JiglioNero and others added 2 commits April 24, 2020 13:36
@JiglioNero @SounD120
Update src/common/packager.ts
9ed9dd7 
Co-Authored-By: Yuri Skorokhodov <v-yuskor@microsoft.com>
@SounD120
Update src/common/packager.ts
324423c
SounD120
SounD120 reviewed Apr 27, 2020
View reviewed changes
src/common/packager.ts Outdated Show resolved Hide resolved
@SounD120 SounD120 merged commit 294ec6b into master Apr 29, 2020
@SounD120 SounD120 deleted the issue#1252-fix-assets-load-for-expo37 branch April 29, 2020 14:58
JiglioNero added a commit that referenced this pull request May 18, 2020
@JiglioNero @SounD120
@RedMickey @dependabot @molant
Merging master and dev (#1283)
de838bb 
* Add telemetry for Expo host types (#1204)

* Added handling for an iOS device target concrete device (#1207)

* Added handling for a iOS device target concrete device using format 'device=<iOS_device_name>'
* Update docs

* Add expo tests for different Expo network scenarios (#1208)

* Refactor Expo tests

* Fix dependency vulnerabilities (#1219)

* Bump acorn from 6.4.0 to 6.4.1 in /test/smoke/package (#1222)

Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@6.4.0...6.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump minimist from 1.2.0 to 1.2.2

Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

* Bump vulnerable dependencies

* Bump several dependencies, fix security vulnerabilities (#1224)

* Fix use of custom Xcode scheme in iOS project (#1213)

* Add unit tests

* Prepare for 0.14.2 (#1225)

* Fix security vulnerabilities in mkdirp package (#1227)

* Fix minimist security vulnerabilities
https://npmjs.com/advisories/1179

* Add YAML pipelines for the smoke tests (#1234)

* Enhance error message in case of error when projectRoot parameter is missing (#1237)

* Add unit tests YAML pipelines (#1241)

* Fix YAML master pipeline (#1244)

* Bump React Native version up to 0.62.0 in smoke tests (#1240)

* Bump RN version up to 0.62.0

* Update Hermes build.gradle

* Fix artifacts generation (#1245)

* Fix smoke tests for Expo 37 SDK (#1247)

* docs: reorganize content of readme.md (#1243)

* transfer launch params (env and envFIle) to packager (#1248)

* transfer launch params (env and envFIle) to packager
add runOption setter to packager for transer launch params

* transfer launch params (env and envFIle) to packager  add runOption setter to packager for transer launch params change args for getEnvArguments and create tests to getEnvArguments

* Update src/common/packager.ts

Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>

* Update test/extension/generalMobilePlatform.test.ts

Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>

* port and status indicator from packager getters to codestyle

* change dir of tmp .env and add able to use standart .env file ro project path

* Update test/extension/generalMobilePlatform.test.ts

Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>

* Update test/extension/generalMobilePlatform.test.ts

Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>

* Update test/extension/generalMobilePlatform.test.ts

Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>

* Update test/extension/generalMobilePlatform.test.ts

Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>

* Update test/extension/generalMobilePlatform.test.ts

Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>

* Update test/extension/generalMobilePlatform.test.ts

Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>

* add to readme description  of passing custom enviroment variables for the `react-native` packager

* Update README.md

Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>

* Update README.md

Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>

* fix logic for choice source for env vars
and add check and test for file еxistence

* add some more info to readme

* Update README.md

Co-Authored-By: Yuri Skorokhodov <yurapkr@yandex.ru>

* Update README.md

Co-Authored-By: RedMickey <33267199+RedMickey@users.noreply.github.com>

Co-authored-by: Mikhail Suendukov <mikhail.suendukov@inyar.ru>
Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com>
Co-authored-by: Yuri Skorokhodov <yurapkr@yandex.ru>
Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

* Update command palette commands table in documentation (#1250)

* Update Expo documentation (#1251)

* Prepare for 0.15.0 (#1255)

* Migrate unit tests to vscode-test  (#1256)

* Fix security vulnerabilities (#1253)

* Fix vulnerabilities

* Fix fonts usage for Expo 37 (#1260)

* Fix runOptions check for packager (#1264)

* add check run options

* remove font fix for expo 37 from changelog

* fix getiing of status indicator

* fix unit tests in gulpfile

* remove extensions tests from ci

* fix .ci -remove debugger tests

* cleanup

* Delete yarn.lock

Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>
Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Antón Molleda <molant@users.noreply.github.com>
Co-authored-by: Mikhail Suendukov <mikhail.suendukov@inyar.ru>
Co-authored-by: Yuri Skorokhodov <yurapkr@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SounD120 SounD120 SounD120 approved these changes

@RedMickey RedMickey RedMickey approved these changes

Assignees

@JiglioNero JiglioNero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App refuses to load with expo and @expo/vector-icons
3 participants
@JiglioNero @SounD120 @RedMickey