Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Add jsEnable option #154

Merged
merged 2 commits into from Jan 6, 2017
Merged

Add jsEnable option #154

merged 2 commits into from Jan 6, 2017

Conversation

YuichiNukiyama
Copy link
Contributor

fixes #149

@sorenlouv
Copy link

Looking forward to this being merged in.

@egamma egamma merged commit dda451f into microsoft:master Jan 6, 2017
@YuichiNukiyama YuichiNukiyama deleted the jsenable_option branch January 6, 2017 23:06
@egamma
Copy link
Member

egamma commented Jan 9, 2017 •
edited

@YuichiNukiyama thanks 🌷 for the PR . I've published it as part of vscode-tslint 0.8.1. I've changed the default to false, since users where confused that tslint is active by default on .js files.

We should revisit the implementation once the language server protocol 3.0 is out. With this protocol version we can dynamically change the configuration so that .js files are not synchronized to the server, when jsEnabled is set to false. The current implementation always syncs over the JS files and then just ignores them when jsEnabled is set to false.

@egamma egamma added this to the January 2015 milestone Jan 26, 2017
@egamma
Copy link
Member

egamma commented Feb 5, 2019

@jacobbogers what issue do you exactly refer to? The PR is about enabling a jsEnable option and this is in place since a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2017
3 participants
@YuichiNukiyama @sorenlouv @egamma