This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
dependencies updated #335
Closed
dependencies updated #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@cancerberoSgx thanks for the PR, I will combine this updates with an update to the new Language Server libraries. I will look into simplifying the setup and support for travis, makes total sense. |
egamma
added a commit
that referenced
this pull request
Jun 4, 2018
|
@cancerberoSgx I´ve merged the PR manually and updated again to the latest versions, thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW would be nice to set up CI like travis or appveyor just to make sure PRs are not breaking the extension. I tried to debug manually the most I can but running the test of this extension is very very hard and I give up. Please implement a simple npm test command that perform most of the manual work you detail in /README.md !! You can use shelljs to copy things and execute commands programatically very easily.