Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update approved badges url from VSMarketplaceBadges #799

Closed
equiman opened this issue Dec 11, 2022 · 8 comments · Fixed by #798
Closed

Update approved badges url from VSMarketplaceBadges #799

equiman opened this issue Dec 11, 2022 · 8 comments · Fixed by #798
Assignees
Labels
feature-request Request for new features or functionality

Comments

@equiman
Copy link

equiman commented Dec 11, 2022

https://code.visualstudio.com/api/references/extension-manifest#approved-badges

The approved badges list includes the URL vsmarketplacebadge.apphb.com but his domain was changed to https://vsmarketplacebadges.dev

Is it possible to replace it to avoid this error when publishing with vsce command?

image

@sandy081 sandy081 assigned joaomoreno and unassigned sandy081 Dec 12, 2022
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Dec 14, 2022
@joaomoreno joaomoreno transferred this issue from microsoft/vscode Dec 14, 2022
@eamodio
Copy link
Contributor

eamodio commented Dec 16, 2022

@joaomoreno @sandy081 Can we get this released? It looks like the marketplace is now blocking the old urls, and VSCE (until this goes out) won't allow the new ones.

@isidorn
Copy link
Contributor

isidorn commented Dec 21, 2022

We have updated vsce so this should no longer be a problem.
@eamodio let us know if you still see an issue. Thanks for your understanding.

@estruyf
Copy link

estruyf commented Dec 23, 2022

@isidorn seems the issue on vsce got fixed, but there is still some validation issue on the marketplace.

I just tried to publish one of my extensions, and vsce mentioned it got published:

image

A minute later, I got the following email:

image

The log file mentions:

Error processing 'eliostruyf.vscode-front-matter-beta' SVG reference in file '/extension/README.md'. Your reference to the SVG image ‘https://vsmarketplacebadge.apphb.com/version/eliostruyf.vscode-front-matter.svg’ is not supported.

This worked fine for a long time, only started to fail since a couple of days.

@PKief
Copy link

PKief commented Dec 23, 2022

@estruyf it seems that SVG images from https://vsmarketplacebadge.apphb.com are not longer working anyways. You've to replace them with this URL https://vsmarketplacebadges.dev/.

See this issue for reference:

cssho/VSMarketplaceBadge#18 (comment)

@estruyf
Copy link

estruyf commented Dec 23, 2022

@PKief I know, but the same happens for the new one.

@equiman
Copy link
Author

equiman commented Dec 23, 2022

Did you try updating the vsce version?

@estruyf
Copy link

estruyf commented Dec 23, 2022

@equiman it is on the marketplace, not the tool itself as the latest update indeed fixed publishing. It seems that the marketplace performs a similar check.

@estruyf
Copy link

estruyf commented Dec 24, 2022

It seems the issue was indeed on my end, it was a combination of tests and not using the correct vsce dependency. It seems vsce became @vscode/vsce, so needed to do an update in my GitHub action. Instead of npx vsce, now it needs to be npx @vscode/vsce.

So the marketplace seems to invalidate the extension only when the old URL is used, when the new one is used. All is fine.

amit-kulkarni-in added a commit to amit-kulkarni-in/vscode-docs that referenced this issue Jan 5, 2023
vsmarketplacebadge.apphb.com is currently not supported and is replaced with vsmarketplacebadges.dev . More details in microsoft/vscode-vsce#799 . Updating the document due to this change.
gregvanl pushed a commit to microsoft/vscode-docs that referenced this issue Jan 6, 2023
* Update Approved Badges

vsmarketplacebadge.apphb.com is currently not supported and is replaced with vsmarketplacebadges.dev . More details in microsoft/vscode-vsce#799 . Updating the document due to this change.

* Update extension-manifest.md
amit-kulkarni-in added a commit to amit-kulkarni-in/azure-devops-docs that referenced this issue Jan 6, 2023
vsmarketplacebadge.apphb.com is currently not supported and is replaced with vsmarketplacebadges.dev . More details in microsoft/vscode-vsce#799 . Updating the document due to this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants