Fix Settings indicator tabIndexes (#171770)

Fix tabIndex issues Ref #167470
microsoft · Jan 19, 2023 · 04119d2 · 04119d2
1 parent 40e5320
commit 04119d2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/vs/workbench/contrib/preferences/browser/settingsEditorSettingIndicators.ts b/src/vs/workbench/contrib/preferences/browser/settingsEditorSettingIndicators.ts
@@ -266,7 +266,7 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
 
 		const currentlyFocusedIndicator = indicators[this.focusedIndex];
 		const previousFocusedElement = currentlyFocusedIndicator.focusElement ?? currentlyFocusedIndicator.element;
-		previousFocusedElement.removeAttribute('tabIndex');
+		previousFocusedElement.tabIndex = -1;
 
 		this.focusedIndex = index;
 	}
@@ -364,6 +364,7 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
 
 				const overriddenScope = element.overriddenScopeList[0];
 				const view = DOM.append(this.scopeOverridesIndicator.element, $('a.modified-scope', undefined, this.getInlineScopeDisplayText(overriddenScope)));
+				view.tabIndex = -1;
 				this.scopeOverridesIndicator.focusElement = view;
 				const onClickOrKeydown = (e: UIEvent) => {
 					const [scope, language] = overriddenScope.split(':');