Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change settings indicators key handling so that one can use arrow keys #167470

Closed
Tracked by #159088
rzhao271 opened this issue Nov 28, 2022 · 1 comment · Fixed by #171685
Closed
Tracked by #159088

Change settings indicators key handling so that one can use arrow keys #167470

rzhao271 opened this issue Nov 28, 2022 · 1 comment · Fixed by #171685
Assignees
@rzhao271
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2023

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Nov 28, 2022 •
edited
Loading

Change the key event handling so that the user can tab once into the indicators container, and then use left/right arrows to focus on different indicators.
@rzhao271 rzhao271 mentioned this issue Nov 28, 2022
Closed
3 tasks
@rzhao271 rzhao271 changed the title Change the key event handling so that the user can tab once into the indicators container, and then use left/right arrows to focus on different indicators. Change settings indicators key handling so that one can use arrow keys Nov 28, 2022
@rzhao271 rzhao271 self-assigned this Nov 28, 2022
@rzhao271 rzhao271 added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Nov 28, 2022
@rzhao271 rzhao271 added this to the December 2022 milestone Nov 28, 2022
@rzhao271 rzhao271 mentioned this issue Nov 29, 2022
Closed
@rzhao271 rzhao271 modified the milestones: December 2022, January 2023 Dec 6, 2022
@kieferrm kieferrm mentioned this issue Jan 2, 2023
Closed
@rzhao271 rzhao271 mentioned this issue Jan 18, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 18, 2023
rzhao271 added a commit that referenced this issue Jan 19, 2023
@rzhao271
Fix tabIndex issues
b4df68c 
Ref #167470
@rzhao271 rzhao271 mentioned this issue Jan 19, 2023
Merged
rzhao271 added a commit that referenced this issue Jan 19, 2023
@rzhao271
Fix Settings indicator tabIndexes (#171770)
04119d2 
Fix tabIndex issues

Ref #167470
@rzhao271 rzhao271 modified the milestones: February 2023, January 2023 Jan 20, 2023
@rzhao271
Copy link
Contributor Author

  1. In the Settings editor, search editor spaces @lang:yaml
  2. Focus on the editor.insertSpaces setting.
  3. Pressing tab should focus on the first indicator.
  4. Tabbing again should go to the checkbox.
  5. Shift-tabbing twice from there should focus the entire setting again.
  6. Tab again to the indicator. The left and right arrow keys, along with the home and end keys should allow the user to focus onto the other indicators.
  7. The indicators container should keep track of the focused indicator. If the second indicator is focused, and the user tabs to the checkbox and back, the second indicator should be the one focused rather than the first one.

@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jan 23, 2023
@jrieken jrieken added the verified Verification succeeded label Jan 25, 2023
@jrieken jrieken mentioned this issue Jan 25, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Add keybindings to Settings editor indicators microsoft/vscode
3 participants
@jrieken @rzhao271 @vscodenpa