Fixes Parsing errors not showing in Problems tab when running "lint w…

…hole folder" task (eslint #436)
microsoft · May 11, 2018 · 08169a4 · 08169a4
1 parent c97cd48
commit 08169a4
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/vs/workbench/parts/tasks/common/problemMatcher.ts b/src/vs/workbench/parts/tasks/common/problemMatcher.ts
@@ -260,10 +260,12 @@ abstract class AbstractLineMatcher implements ILineMatcher {
 	private fillProperty(data: ProblemData, property: keyof ProblemData, pattern: ProblemPattern, matches: RegExpExecArray, trim: boolean = false): void {
 		if (Types.isUndefined(data[property]) && !Types.isUndefined(pattern[property]) && pattern[property] < matches.length) {
 			let value = matches[pattern[property]];
-			if (trim) {
-				value = Strings.trim(value);
+			if (value !== void 0) {
+				if (trim) {
+					value = Strings.trim(value);
+				}
+				data[property] = value;
 			}
-			data[property] = value;
 		}
 	}
 
@@ -1191,7 +1193,7 @@ class ProblemPatternRegistryImpl implements IProblemPatternRegistry {
 				file: 1
 			},
 			{
-				regexp: /^\s+(\d+):(\d+)\s+(error|warning|info)\s+(.+?)\s\s+(.*)$/,
+				regexp: /^\s+(\d+):(\d+)\s+(error|warning|info)\s+(.+?)(?:\s\s+(.*))?$/,
 				line: 1,
 				character: 2,
 				severity: 3,