Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARIA role values and ARIA 1.1 attributes #436

Merged
merged 6 commits into from
Nov 22, 2015
Merged

Add ARIA role values and ARIA 1.1 attributes #436

merged 6 commits into from
Nov 22, 2015

Conversation

dstorey
Copy link
Member

@dstorey dstorey commented Nov 22, 2015

Updates #320 to:

  • Include ARIA 1.1 attributes:
    • aria-colcount
    • aria-colindex
    • aria-colspan'
    • aria-current
    • aria-describedat
    • aria-errormessage
    • aria-kbdshortcuts
    • aria-modal
    • aria-placeholder
    • aria-roledescription
    • aria-rowcount
    • aria-rowindex
    • aria-rowspan
  • Add the valid values for the role attribute from ARIA 1.1
    • Widget Roles
    • Document Structure Roles
    • Landmark Roles

For the roles, I started a new line for each category of role so that it easier to see where each starts when maintaining the list. I also hard wrapped in categories with many items to keep same max line lengths as the file.

@msftclas
Copy link

Hi @dstorey, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (David Storey). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

aeschli added a commit that referenced this pull request Nov 22, 2015
Add ARIA role values and ARIA 1.1 attributes
@aeschli aeschli merged commit e807c0e into microsoft:master Nov 22, 2015
@aeschli
Copy link
Contributor

aeschli commented Nov 22, 2015

@dstorey You are awesome! Thanks a lot.

dbaeumer added a commit that referenced this pull request May 11, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants