Merge pull request #56595 from Microsoft/misolori/review-comment

Update review comment styles
microsoft · Aug 16, 2018 · 5b43c8f · 5b43c8f
2 parents 44a453a + 1b61c2a
commit 5b43c8f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/vs/workbench/parts/comments/electron-browser/commentsEditorContribution.ts b/src/vs/workbench/parts/comments/electron-browser/commentsEditorContribution.ts
@@ -17,7 +17,7 @@ import { EmbeddedCodeEditorWidget } from 'vs/editor/browser/widget/embeddedCodeE
 import { IEditorContribution } from 'vs/editor/common/editorCommon';
 import { IRange } from 'vs/editor/common/core/range';
 import * as modes from 'vs/editor/common/modes';
-import { peekViewEditorBackground, peekViewResultsBackground, peekViewResultsSelectionBackground } from 'vs/editor/contrib/referenceSearch/referencesWidget';
+import { peekViewResultsBackground, peekViewResultsSelectionBackground, peekViewTitleBackground } from 'vs/editor/contrib/referenceSearch/referencesWidget';
 import { IContextKey, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey';
 import { ServicesAccessor, IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
 import { KeybindingsRegistry, KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry';
@@ -602,7 +602,7 @@ registerThemingParticipant((theme, collector) => {
 			`}`);
 	}
 
-	let monacoEditorBackground = theme.getColor(peekViewEditorBackground);
+	let monacoEditorBackground = theme.getColor(peekViewTitleBackground);
 	if (monacoEditorBackground) {
 		collector.addRule(
 			`.monaco-editor .review-widget .body .comment-form .review-thread-reply-button {` +

diff --git a/src/vs/workbench/parts/comments/electron-browser/media/review.css b/src/vs/workbench/parts/comments/electron-browser/media/review.css
@@ -160,15 +160,15 @@
 .monaco-editor .review-widget .body .comment-form.expand .monaco-editor,
 .monaco-editor .review-widget .body .comment-form.expand .form-actions {
 	display: block;
-	box-sizing: border-box;
+	box-sizing: content-box;
 }
 
 .monaco-editor .review-widget .body .comment-form .review-thread-reply-button {
 	text-align: left;
 	display: block;
 	width: 100%;
 	resize: vertical;
-	border-radius: 3px;
+	border-radius: 0;
 	box-sizing: border-box;
 	padding: 6px 12px;
 	font-weight: 600;
@@ -191,6 +191,7 @@
 	max-height: 500px;
 	border-radius: 3px;
 	border: 0px;
+	padding: 6px 0 6px 12px;
 }
 
 .monaco-editor .review-widget .body .comment-form .form-actions {
@@ -222,6 +223,10 @@
 	cursor: pointer;
 }
 
+.monaco-editor .review-widget .head .review-title .filename:empty::after {
+	content: "Start discussion";
+}
+
 .monaco-editor .review-widget .head .review-title .dirname:not(:empty) {
 	font-size: 0.9em;
 	margin-left: 0.5em;