Update review comment styles #56595
Merged
Update review comment styles #56595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
reviewed
Aug 16, 2018
| @@ -17,7 +17,7 @@ import { EmbeddedCodeEditorWidget } from 'vs/editor/browser/widget/embeddedCodeE | |||
| import { IEditorContribution } from 'vs/editor/common/editorCommon'; | |||
| import { IRange } from 'vs/editor/common/core/range'; | |||
| import * as modes from 'vs/editor/common/modes'; | |||
| import { peekViewEditorBackground, peekViewResultsBackground, peekViewResultsSelectionBackground } from 'vs/editor/contrib/referenceSearch/referencesWidget'; | |||
| import { peekViewEditorBackground, peekViewResultsBackground, peekViewResultsSelectionBackground, peekViewTitleBackground } from 'vs/editor/contrib/referenceSearch/referencesWidget'; | |||
There was a problem hiding this comment.
Looks like peekViewEditorBackground is unused
RMacfarlane
reviewed
Aug 16, 2018
| @@ -602,7 +602,7 @@ registerThemingParticipant((theme, collector) => { | |||
| `}`); | |||
| } | |||
|
|
|||
| let monacoEditorBackground = theme.getColor(peekViewEditorBackground); | |||
| let monacoEditorBackground = theme.getColor(peekViewTitleBackground); | |||
There was a problem hiding this comment.
This looks better on most themes, but on Quiet Light it matches the rest of the background. Should we use something else like the input background? Or do you think it looks ok on Quiet Light?
There was a problem hiding this comment.
I noticed on some themes this does blend in. I thought about using the input background but then that would mean we'd need to use it in the text area, which currently uses editorBackground and was what I was trying to match.
Here's what it would look like if we used the input bg colo. Thoughts?
There was a problem hiding this comment.
That looks good to me 👍
vikaskyadav
approved these changes
Aug 16, 2018
RMacfarlane
approved these changes
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206 #57
Before
After
