Poor updating/scrolling/rendering of notebooks

Fixes #148164
microsoft · May 19, 2022 · 5f459de · 5f459de
1 parent 6c1dcc2
commit 5f459de
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/build/gulpfile.hygiene.js b/build/gulpfile.hygiene.js
@@ -39,9 +39,13 @@ function checkPackageJSON(actualPath) {
 const checkPackageJSONTask = task.define('check-package-json', () => {
 	return gulp.src('package.json').pipe(
 		es.through(function () {
+			console.log(`${Date.now() / 1000}: 1`);
 			checkPackageJSON.call(this, 'remote/package.json');
+			console.log(`${Date.now() / 1000}: 2`);
 			checkPackageJSON.call(this, 'remote/web/package.json');
+			console.log(`${Date.now() / 1000}: 3`);
 			checkPackageJSON.call(this, 'build/package.json');
+			console.log(`${Date.now() / 1000}: 4`);
 		})
 	);
 });

diff --git a/build/hygiene.js b/build/hygiene.js
@@ -11,6 +11,7 @@ const path = require('path');
 const fs = require('fs');
 const pall = require('p-all');
 const { all, copyrightFilter, unicodeFilter, indentationFilter, tsFormattingFilter, eslintFilter } = require('./filters');
+const debug = require('gulp-debug');
 
 const copyrightHeaderLines = [
 	'/*---------------------------------------------------------------------------------------------',
@@ -150,8 +151,10 @@ function hygiene(some, linting = true) {
 	const productJsonFilter = filter('product.json', { restore: true });
 	const unicodeFilterStream = filter(unicodeFilter, { restore: true });
 
+	console.log(`${Date.now() / 1000}: ${JSON.stringify(input)}`);
 	const result = input
 		.pipe(filter((f) => !f.stat.isDirectory()))
+		.pipe(debug('hi'))
 		.pipe(productJsonFilter)
 		.pipe(process.env['BUILD_SOURCEVERSION'] ? es.through() : productJson)
 		.pipe(productJsonFilter.restore)
@@ -267,12 +270,14 @@ if (require.main === module) {
 	});
 
 	if (process.argv.length > 2) {
+		console.log(`1`);
 		hygiene(process.argv.slice(2)).on('error', (err) => {
 			console.error();
 			console.error(err);
 			process.exit(1);
 		});
 	} else {
+		console.log(`2`);
 		cp.exec(
 			'git diff --cached --name-only',
 			{ maxBuffer: 2000 * 1024 },

diff --git a/...rkbench/contrib/notebook/browser/contrib/viewportCustomMarkdown/viewportCustomMarkdown.ts b/...rkbench/contrib/notebook/browser/contrib/viewportCustomMarkdown/viewportCustomMarkdown.ts
@@ -62,7 +62,7 @@ class NotebookViewportContribution extends Disposable implements INotebookEditor
 	}
 
 	private _warmupViewportNow() {
-		if (this._notebookEditor.isDisposed) {
+		if (!this._notebookEditor.isDisposed) {
 			return;
 		}