Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor updating/scrolling/rendering of notebooks #148164

Closed
jrieken opened this issue Apr 26, 2022 · 5 comments
Closed

Poor updating/scrolling/rendering of notebooks #148164

jrieken opened this issue Apr 26, 2022 · 5 comments
Assignees
@roblourens
Labels
important Issue identified as high-priority notebook papercut 🩸 A particularly annoying issue impacting someone on the team verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2022

Comments

@jrieken
Copy link
Member

jrieken commented Apr 26, 2022

During the update/refresh and while scrolling, the notebook looks and feels bad. Markdown headers jump up/down and overlay. This happens everywhere: safari, chrome, edge, and desktop and isn't some random fluke but repros

Recording:

Screen.Recording.2022-04-26.at.16.55.16.mov

Selection of captures:
Screenshot 2022-04-26 at 17 03 51
Screenshot 2022-04-26 at 17 03 33
Screenshot 2022-04-26 at 17 03 43
@jrieken jrieken added important Issue identified as high-priority notebook papercut 🩸 A particularly annoying issue impacting someone on the team labels Apr 26, 2022
@byehack
Copy link

byehack commented Apr 27, 2022

True. it sometimes becomes very annoying with cpu/memory leak.

@byehack
Copy link

byehack commented May 3, 2022

Rec.0003.mp4

Untitled-1.zip

@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@roblourens roblourens added this to the May 2022 milestone May 18, 2022
roblourens added a commit that referenced this issue May 18, 2022
@roblourens
Poor updating/scrolling/rendering of notebooks
1f8ad3e 
Towards #148164
@roblourens roblourens mentioned this issue May 18, 2022
Merged
roblourens added a commit that referenced this issue May 18, 2022
@roblourens
Also render outputs/markdowns a viewport above the current viewport, …
44ffce2 
…as well as below

Towards #148164
roblourens added a commit that referenced this issue May 19, 2022
@roblourens
Also render outputs/markdowns a viewport above the current viewport, …
550dc55 
…as well as below

Towards #148164
roblourens added a commit that referenced this issue May 19, 2022
@roblourens
Render outputs a viewport above as well as below (#149879)
55abdae 
* Also render outputs/markdowns a viewport above the current viewport, as well as below
Towards #148164

* Update docs and add background color to svg
roblourens added a commit that referenced this issue May 19, 2022
@roblourens
Poor updating/scrolling/rendering of notebooks
5f459de 
Fixes #148164
roblourens added a commit that referenced this issue May 24, 2022
@roblourens
Poor scrolling behavior after notebook model reset
ba5340b 
Towards #148164
@roblourens roblourens mentioned this issue May 24, 2022
Closed
roblourens added a commit that referenced this issue May 24, 2022
@roblourens
Poor scrolling behavior after notebook model reset
39e4db2 
Towards #148164
@roblourens roblourens mentioned this issue May 24, 2022
Merged
@rebornix rebornix modified the milestones: May 2022, June 2022 Jun 1, 2022
roblourens added a commit that referenced this issue Jun 6, 2022
@roblourens
Poor scrolling behavior after notebook model reset (#150306)
05d23f1 
* Poor scrolling behavior after notebook model reset
Towards #148164

* Update scroll dimensions before scrolltop, otherwise the scrollTop will be clamped when a cell above the viewport got larger

* Add explanation to update order

* Revert "Update scroll dimensions before scrolltop, otherwise the scrollTop will be clamped when a cell above the viewport got larger"

This reverts commit 35c61b2.

* Remove leftover comment
@kieferrm kieferrm mentioned this issue Jun 11, 2022
Closed
99 tasks
@roblourens
Copy link
Member

roblourens commented Jun 27, 2022 •
edited
Loading

We fixed a few things here, and I'll call this issue fixed. To trigger the same case as in the original report:

  • Open some notebook, scroll to the bottom
  • In a terminal, touch <path to notebook>
  • The notebook may flicker a little as its model is reloaded
  • Scroll up
  • You should not see wild flickering of markdown cells

There will still be some layout shifts. I spent awhile trying to eliminate the scroll shift that you will see when you run touch. That turns out to be essentially impossible.

@jrieken
Copy link
Member Author

jrieken commented Jun 29, 2022

This is much better and it's great to see progress. I wouldn't call the overall experience great - there is still the usual flicker when scrolling for the first time

@jrieken jrieken reopened this Jun 29, 2022
@jrieken jrieken closed this as completed Jun 29, 2022
@jrieken jrieken added the verification-needed Verification of issue is requested label Jun 29, 2022
@jrieken
Copy link
Member Author

jrieken commented Jun 29, 2022

I don't know why it re-opened... Creating a separate issue for the "other" flicker

@jrieken jrieken reopened this Jun 29, 2022
@jrieken jrieken mentioned this issue Jun 29, 2022
Closed
@jrieken jrieken added the verified Verification succeeded label Jun 29, 2022
@rebornix rebornix removed their assignment Jun 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
important Issue identified as high-priority notebook papercut 🩸 A particularly annoying issue impacting someone on the team verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

No branches or pull requests
6 participants
@roblourens @rebornix @jrieken @greazer @byehack and others