addressing additional comments

microsoft · Jul 15, 2019 · d235f18 · d235f18
1 parent 528f580
commit d235f18
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/extensions/git/src/git.ts b/extensions/git/src/git.ts
@@ -1526,13 +1526,13 @@ export class Repository {
 		}
 	}
 
-	async dropStash(index?: number): Promise<void> {
+	async dropStash(index: number): Promise<void> {
 		const args = ['stash', 'drop'];
 
-		try {
-			if (typeof index === 'number') {
-				args.push(`stash@{${index}}`);
+		if (typeof index === 'number') {
+			args.push(`stash@{${index}}`);
 
+			try {
 				await this.run(args);
 			}
 		} catch (err) {