Have FileSystemError adopt ErrorNoTelemetry (#155885)

* Cleanup FileSystemErrors * Implement the naive solution * hm? Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
microsoft · Aug 16, 2022 · f152032 · f152032
1 parent 2c93c17
commit f152032
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/vs/base/common/errors.ts b/src/vs/base/common/errors.ts
@@ -243,7 +243,7 @@ export class ErrorNoTelemetry extends Error {
 
 	constructor(msg?: string) {
 		super(msg);
-		this.name = 'ErrorNoTelemetry';
+		this.name = 'CodeExpectedError';
 	}
 
 	public static fromError(err: Error): ErrorNoTelemetry {
@@ -258,7 +258,7 @@ export class ErrorNoTelemetry extends Error {
 	}
 
 	public static isErrorNoTelemetry(err: Error): err is ErrorNoTelemetry {
-		return err.name === 'ErrorNoTelemetry';
+		return err.name === 'CodeExpectedError';
 	}
 }
 

diff --git a/src/vs/platform/telemetry/common/errorTelemetry.ts b/src/vs/platform/telemetry/common/errorTelemetry.ts
@@ -7,6 +7,7 @@ import { binarySearch } from 'vs/base/common/arrays';
 import { errorHandler, ErrorNoTelemetry } from 'vs/base/common/errors';
 import { DisposableStore, toDisposable } from 'vs/base/common/lifecycle';
 import { safeStringify } from 'vs/base/common/objects';
+import { FileOperationError } from 'vs/platform/files/common/files';
 import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
 
 type ErrorEventFragment = {
@@ -87,7 +88,8 @@ export default abstract class BaseErrorTelemetry {
 		}
 
 		// If it's the no telemetry error it doesn't get logged
-		if (ErrorNoTelemetry.isErrorNoTelemetry(err)) {
+		// TOOD @lramos15 hacking in FileOperation error because it's too messy to adopt ErrorNoTelemetry. A better solution should be found
+		if (ErrorNoTelemetry.isErrorNoTelemetry(err) || err instanceof FileOperationError) {
 			return;
 		}