Have FileSystemError adopt ErrorNoTelemetry

[lramos15]

Fixes #155492

Allow setting error name with ErrorNoTelemetry. Tested on throwing a filesystem error but it presents a modal without any notion of ErrorNoTelemetry. If anyone has a notifcation example I can also test making sure it doesn't show up there.

[sbatten]

@lramos15 does it have ENOPRO in the dialog?

[lramos15]

@lramos15 does it have ENOPRO in the dialog?

I didn't test ENOPRO specifically I tested the error listed in #155492 but the modal just had the message and not the name

[bpasero]

This may be user facing in certain cases, so what is the reason for making the error name rather cryptic by concatenating ErrorNoTelemetry and the original name? I would rather use something that is more generic, since I believe the main intent is to implement isErrorNoTelemetry properly:

public override set name(newName: string) {
	this._name = `${newName} (CodeExpectedError)`;
}

public static isErrorNoTelemetry(err: Error): err is ErrorNoTelemetry {
	return err.name.contains('(CodeExpectedError)');
}

I think CodeExpectedError can be something else too, if we want to go with node.js notion, maybe EEXPECTED).

[lramos15]

This may be user facing in certain cases, so what is the reason for making the error name rather cryptic by concatenating ErrorNoTelemetry and the original name? I would rather use something that is more generic, since I believe the main intent is to implement isErrorNoTelemetry properly:

Yeah we can go with anything here. I think the main goal with sticking with ErrorNoTelemetry is to also try and clean it wherever it shows up

[lramos15]

I went with a very simple solution here as further exploration looked like it was going to break things down the line. I believe FileSystemErrors are the most complex case so my fix is ok but I wish everything could go through ErrorNoTelemetry to make it clear. Will reinvestigate what we can do to unblock the custom error properties in the future but for now this helps cleanup our data pipeline by removing file system errors