Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Code Insider] InputBox Bug - Active webview prevents cut, copy and paste into input box #101599

Closed
L13 opened this issue Jul 2, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone

Comments

@L13
Copy link

L13 commented Jul 2, 2020

Issue Type: Bug

Hi @mjbvz and @jrieken ,

I found another input focus bug.

  1. Download/Install an extension with a webview like L13 Diff https://marketplace.visualstudio.com/items?itemName=L13RARY.l13-diff.
  2. Open the command palette (Ctrl/Meta+Shift+P) and search for "L13 Diff" or press "Ctrl+L Ctrl+L" on Windows/Linux or "Meta+L Meta+L" on macOS.
  3. If the webview is the active editor, open for example the command palette (Ctrl/Meta+Shift+P) again and try to cut, copy or paste a value into the input box -> Does not work.

If you close the active webview or the webview is not the active editor cut, copy or paste in the input box works.

This bug is not in VS Code <= 1.46.1

PS: Thank you for the previous fix #101201

VS Code version: Code - Insiders 1.47.0-insider (b16b467, 2020-07-01T05:30:11.898Z)
OS version: Darwin x64 19.5.0

and

VS Code version: Code - Insiders 1.47.0-insider (04545fa, 2020-07-02T05:41:12.081Z)
OS version: Darwin x64 19.5.0

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jul 2, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 2, 2020

Good find!

@mjbvz mjbvz closed this as completed in b22fd30 Jul 2, 2020
@mjbvz mjbvz added this to the June 2020 milestone Jul 2, 2020
@mjbvz mjbvz added the webview Webview issues label Jul 2, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 3, 2020
@aeschli
Copy link
Contributor

aeschli commented Jul 6, 2020

Still doesn't work for me.
Version: 1.47.0-insider
Commit: 376d9d9
Date: 2020-07-03T10:15:57.898Z
OS: Linux x64 5.3.0-59-generic

@aeschli aeschli reopened this Jul 6, 2020
@aeschli aeschli added the verification-found Issue verification failed label Jul 6, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 6, 2020

Thanks for testing @aeschli. That is a known separate issue: #101553

For this issue, please just verify that the keyboard shortcuts work when you have a webview open and then open the command palette

@mjbvz mjbvz closed this as completed Jul 6, 2020
@mjbvz mjbvz removed the verification-found Issue verification failed label Jul 6, 2020
@connor4312 connor4312 added the verified Verification succeeded label Jul 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Development

No branches or pull requests

5 participants
@connor4312 @aeschli @L13 @mjbvz and others