Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick outline doesn't focus editor #101657

Closed
jrieken opened this issue Jul 3, 2020 · 2 comments
Closed

Quick outline doesn't focus editor #101657

jrieken opened this issue Jul 3, 2020 · 2 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues regression Something that used to work is now broken verified Verification succeeded
Milestone
June 2020

Comments

@jrieken
Copy link
Member

jrieken commented Jul 3, 2020 •
edited

  • select a file in the explorer, e.g src/vs/base/common/async.ts
  • without clicking into the editor, open quick outline and select an element from the file
  • 馃悰 focus is not in the editor

Jul-03-2020 09-40-11
@bpasero
Copy link
Member

bpasero commented Jul 3, 2020

This is very likely from #93055

@bpasero bpasero assigned chrmarti and unassigned bpasero Jul 3, 2020
@bpasero bpasero added the quick-pick Quick-pick widget issues label Jul 3, 2020
@bpasero bpasero self-assigned this Jul 3, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jul 3, 2020
@bpasero bpasero added this to the June 2020 milestone Jul 3, 2020
@bpasero
Copy link
Member

bpasero commented Jul 3, 2020 •
edited

The quick outline is setting focus to the editor, but it seems that da99f1f is still restoring focus to the previous element.

Imho quick input should check if the focused element is different from where it was before and only restore focus if the focused element is somewhere inside the quick input widget.

@bpasero bpasero added the regression Something that used to work is now broken label Jul 3, 2020
@bpasero bpasero removed their assignment Jul 3, 2020
chrmarti added a commit that referenced this issue Jul 3, 2020
@chrmarti
Check if focus changed (fixes #101657)
9b65ad9
@chrmarti chrmarti mentioned this issue Jul 3, 2020
Merged
@bpasero bpasero added the verified Verification succeeded label Jul 3, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 3, 2020
@chrmarti @gjsjohnmurray
Check if focus changed (fixes microsoft#101657)
131d3ef
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@bpasero @jrieken @chrmarti and others