Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process explorer: remove node.js/electron dependencies #101832

Closed
bpasero opened this issue Jul 7, 2020 · 0 comments · Fixed by #102159
Closed

Process explorer: remove node.js/electron dependencies #101832

bpasero opened this issue Jul 7, 2020 · 0 comments · Fixed by #102159
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment workbench-diagnostics General VS Code built-in diagnostic issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jul 7, 2020

The process explorer depends on:

  • Electron clipboard
  • os node.js module (totalMem)

This should be cleaned up to be ready for sandbox by leveraging the IElectronService instead. You can take a look at the issue reporter for how to get a hold of the electron service:

this.electronService = new ElectronService(configuration.windowId, mainProcessService) as IElectronService;

I think it would be reasonable to add another method to the electron service for accessing os.totalMem().

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment workbench-diagnostics General VS Code built-in diagnostic issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@bpasero @deepak1556 @RMacfarlane and others