Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The header of the details widget of suggests is not word-wrapped sometimes #109717

Closed
tamuratak opened this issue Oct 30, 2020 · 3 comments
Closed
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue suggest IntelliSense, Auto Complete
Milestone

Comments

@tamuratak
Copy link
Contributor

tamuratak commented Oct 30, 2020

Version: 1.51.0-insider
Commit: 2ee8b8c
Date: 2020-10-29T06:00:13.428Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:

  1. Open a TypeScript file.
  2. Type vscode.window. and open suggests and details with Ctrl-Space
  3. The header of the details widget of a suggest
    vscode.window.onDidChangeActiveTerminal is not word-wrapped.
  4. If we want to see the whole header, we have to make the detail ridiculously wider.

Does this issue occur when all extensions are disabled?: Yes

スクリーンショット 2020-10-30 12 53 19

Still not enough wide.

スクリーンショット 2020-10-30 12 53 42

@jrieken jrieken added suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach labels Oct 30, 2020
@jrieken
Copy link
Member

jrieken commented Oct 30, 2020

That's on purpose. You can read more here: #99370 (comment). In short, we auto wrap unless the extension provided multiples lines for the details in which case we don't auto wrap so that we don't interfere with its "ascii art". Tho, we might wanna extend that to says "contains new lines and leading whitespace"

@jrieken jrieken added this to the October 2020 milestone Oct 30, 2020
@jrieken jrieken added polish Cleanup and polish issue and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 30, 2020
@jrieken
Copy link
Member

jrieken commented Oct 30, 2020

Done. The details/header will now "break to fit lines" unless the extension provided new lines followed by intentation.

@MartinGC94
Copy link

I think this change broke the fix for the problem I mentioned here: #29126 (comment) where linebreaks from the extension aren't shown like they should.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue suggest IntelliSense, Auto Complete
Projects
None yet
Development

No branches or pull requests

4 participants
@jrieken @tamuratak @MartinGC94 and others