Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: possibility to change the size of description popup #29126

Closed
feelancer21 opened this issue Jun 20, 2017 · 58 comments
Closed

feature-request: possibility to change the size of description popup #29126

feelancer21 opened this issue Jun 20, 2017 · 58 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan suggest IntelliSense, Auto Complete ux User experience issues
Milestone

Comments

@feelancer21
Copy link

Hello, I am creating a snippet for VS Code with long descriptions. I have noticed that the description popup window in VS Code has a scrollbar, but it would be greater if I can enlarge the window. This seems not to be possible in the current version (1.13.1). It would be better if one can either set the height and width in the preferences or change the size of the popup with mouse dynamically.

Regards steff

@mike-lischke
Copy link

I'd like to add that wrapping in the popup is also a problem and should be avoided (overflow should be horizontally scrollable).

@ramya-rao-a ramya-rao-a added suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues labels Jun 21, 2017
@ramya-rao-a ramya-rao-a assigned stevencl and unassigned ramya-rao-a Jun 27, 2017
@ramya-rao-a
Copy link
Contributor

cc @Microsoft/vscode for thoughts

@stevencl
Copy link
Member

It seems like the problem is that to read long descriptions, you need to scroll. One way to solve that problem without requiring intervention from the user would be to resize the popup dynamically based on the content it needs to display. If we were able to do this, we could make long descriptions more readable without requiring the user to either scroll through the description or to drag out the size of the window to make the content more readable. We currently set the height dynamically, perhaps we could also look at dynamically altering the width to accommodate larger content?

While there would probably still be cases where there simply isn't enough room to show all of the content this would be the preferable solution for me since it allows most users to keep their hand on the keyboard and means that we don't need to worry about what to do with the popup after the user has resized it, then dismissed it (do we keep it at that size, even if it is way too big for the next piece of content, what happens then when the user returns to the same content that caused them to resize etc etc).

I also agree that wrapping inside the popup doesn't seem like the right thing to do since it alters the readability of the content. So if resizing the width of the popup still means content is outside of the viewport, we should add a scroll bar as @mike-lischke suggests.

@stevencl stevencl assigned ramya-rao-a and unassigned stevencl Aug 10, 2017
@ramya-rao-a
Copy link
Contributor

The scrollbar solution is worth pursuing

@nsreenath
Copy link

Large descriptions that usually come as part of a well documented sample code will be easy to read if we put a button to open the entire description in new tab.

@Raydir
Copy link

Raydir commented Dec 19, 2017

I'd love to get a possibility to "resize" this window. Prefered solution would be a setting alike "editor.SuggetionsHeigth" and "editor.SuggetionsWidth" which could be set in pixels.

@lonix1
Copy link

lonix1 commented Jul 19, 2018

Like I said in my other issue:

Please add one or more of the following:

  • Add a setting for "wider IntelliSense popups"
  • Don't wrap
  • Or the best option: allow me to resize the popup horizontally, and automatically remember the width

And while we're at it:

  • the up/down arrows for choosing function overloads are too small

This should be for autocompletion, intellisense and debugging popups (I'm unsure if those are the correct names for vscode). They are all too narrow, and they all wrap. It should be like in regular Visual Studio - we shouldn't have to debate it, just copy what already works.

@Raydir

This comment has been minimized.

@lin1000

This comment has been minimized.

@finalcreator
Copy link

when the import package path is very long , the suggestion window width not fit the long length, characters are truncated!!!

@garfunkel
Copy link

I'd like this feature too - I have to use large font size in my editor, but it makes the popup window dramatically too small in relation to the text size, rendering it ugly/useless.

@lonix1
Copy link

lonix1 commented Sep 19, 2018

Interesting point: one of the most compelling reasons IDEs became popular was that they are aware of what you're doing - i.e. intellisense. And vscode ALREADY HAS this available (and it's very good!), it's just unusable.

So right now, it's hard to say that using vscode is better than using notepad.

Since intellisense is already implemented and working, I don't understand why it isn't made pretty so it becomes usable. This is a very old issue, and affects everyone.

@RuiffCardoso
Copy link

RuiffCardoso commented Oct 23, 2018

After using VSCode for Java for a few months, one of the things I find missing is a better parameter info. When there is a rather large function (long function name or parameters), it gets hard to navigate through the window because they ending part get cut, as seen on the attached picture:

image

In the next example, it also shows how hard it is to know what parameters the function accepts, since you can only see the first parameter.

image

Having an adjustable window, or even a configured fixed size width, would improve code navigation alot.

@jrieken jrieken added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 5, 2020
@jrieken jrieken modified the milestones: Backlog, October 2020 Oct 9, 2020
@garfunkel
Copy link

garfunkel commented Oct 14, 2020

OMG it looks like this is getting some attention. Hell yes hell yes hell yes!

Super excited for this now.

@jrieken
Copy link
Member

jrieken commented Oct 16, 2020

Ok, so this is the plan

  • make the completions-list resizable
  • make the details-pane resizable
  • don't shrink completions-list when details-pane shows

@jerclarke
Copy link

jerclarke commented Oct 20, 2020

This sounds like an amazing improvement!

What happens if it's too big for the window? Details fall down below completions?

@jrieken
Copy link
Member

jrieken commented Oct 21, 2020

FYI - I have merged the first cut into master (#109094). This means next insiders (tomorrow) will have this. There might still be rough edges and bugs but I want to get feedback rather sooner than later.

👉 try this in https://code.visualstudio.com/insiders/ 👈

@miguelsolorio
Copy link
Contributor

@jrieken these updates are 🔥 . Should there be a min-height on the description that caps where the text ends? This feels a bit odd:

Kapture 2020-10-22 at 09 13 20

Also, it appears that the description height doesn't persist even though all others do?

@jerclarke
Copy link

It's possible for the text to be extremely tall, so a min-height couldn't be based on that.

Any chance this update could also give us an option to control the size of the text in these boxes separate from everything else?

@MartinGC94
Copy link

Maybe it's an extension issue, but I don't see linebreaks for the different method overloads in Powershell. Here's how it looks in stable VS code:
image

And here's how it looks in the latest insider version:
image

@jrieken
Copy link
Member

jrieken commented Oct 23, 2020

Any chance this update could also give us an option to control the size of the text in these boxes separate from everything else?

There are these settings: editor.suggestFontSize and editor.suggestLineHeight

@jrieken
Copy link
Member

jrieken commented Oct 23, 2020

@MartinGC94 re #29126 (comment) 👉 #99370

@rwcorbett

This comment has been minimized.

@jrieken
Copy link
Member

jrieken commented Oct 26, 2020

This is done. Will ship with next stable and is already available in insiders. Please file bugs for further work and polish

@jrieken jrieken closed this as completed Oct 26, 2020
@mikecann
Copy link

wooo! been following this for 3 years, excellent news ;)

@mbreslav
Copy link

Will the ability to resize the window also apply to the tooltip/hover window that is used by Hover providers?

@GustavoASC
Copy link
Contributor

This feature is incredible and works perfectly. Thank you very much @jrieken for developing this 😍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan suggest IntelliSense, Auto Complete ux User experience issues
Projects
None yet
Development

No branches or pull requests