Donn't render newline-characters as new lines in suggest details widget

[WebFreak001]

• VSCode Version: 1.45.1
• OS Version: any

Steps to Reproduce:

1. Create an extension providing a completion item with detail set to
   "void writeln(\n\tT...\n)(\n\tT args\n)"

2. Observe that VSCode reordered the detail string in the small view:
   (changed to void writeln( ) T...)
   

3. Observe that the big detail view is missing the indentation: (doesn't work with tabs or with spaces)
   

On the API documentation (https://code.visualstudio.com/api/references/vscode-api#CompletionItem) it says detail is just "A human-readable string with additional information about this item", so I wouldn't expect VSCode to split it up into lines, reorder the lines and show that in the short UI.

The missing indentation part is probably a separate issue from this though.

[jrieken]

Let's try this for October...

[WebFreak001]

I actually quite liked that the suggest details widget showed newlines, instead my issue was that the small preview had mixed up the string somehow and I mentioned in the side that the details widget showed the string correctly, but without indentation.

For complex strings I think it's actually a good idea to keep the details widget newlines and properly embrace it as a feature.

[jrieken]

instead my issue was that the small preview had mixed up the string somehow and

Yeah, it will always do that because it needs to wrap lines because of spacing and to honour the actual line breaks. That's why it is always a mess

[WebFreak001]

why was the string void writeln(\n\tT...\n)(\n\tT args\n) cut to void writeln( ) T and not cut to void writeln( T ) though?

[jrieken]

Reopen for discussion

[MartinGC94]

I was sent here from this comment: #29126 (comment) but I'm not sure what to say. It doesn't seem like anyone here wanted newlines removed from the detailed view, so let's just not do that.

I don't personally care about the small view, but I agree with the OP that it's weird if void writeln(\n\tT...\n)(\n\tT args\n) gets shortened to void writeln( ) T in the small view.

[jrieken]

I pushed a change to render line breaks as they are. No line breaks that are inserted to fit into the rendering box

[jrieken]

to verify:

• open suggest details for various completions like TS auto imports, TS DOM types like AbortController etc pp
• make sure the details isn't wrapped artificially but only at lines breaks the extension/provider has defined

[jrieken]

@Tyriar for verification

[jrieken]

Refinement: when details (as provided by the extension) contain line breaks then we'll don't allow render-only breaks but when details are a single line we do wrap for rendering.

[JacksonKearl]

Spot on.

[Tyriar]

The primary case I had issue with is covered now:

I found one minor issue when long symbols are used, but you could argue that I just need to resize the detail and I will do that, so I'm fine with this:

Thanks for following this up 👍