Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsconfig.json does not support jsx=reaxt-jsx #112710

Closed
mstssk opened this issue Dec 17, 2020 · 1 comment · Fixed by SchemaStore/schemastore#1410
Closed

jsconfig.json does not support jsx=reaxt-jsx #112710

mstssk opened this issue Dec 17, 2020 · 1 comment · Fixed by SchemaStore/schemastore#1410
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
January 2021

Comments

@mstssk
Copy link

mstssk commented Dec 17, 2020

  • VSCode Version: 1.52.1
  • OS Version: macOS 10.15.7, (Darwin x64 19.6.0)

Steps to Reproduce:

  1. Put jsonfig.json in any dirrectory with bellow content:
{
  "compilerOptions": {
    "jsx": "react-jsx"
  }
}
  1. Open jsonfig.json.
  2. VS Code shows bellow warning:

When down-level compiling, specify JSX code generation: 'preserve', 'react', or 'react-native'. Requires TypeScript version 2.2 or later.
Value is not accepted. Valid values: "preserve", "react", "react-native".(1)

vscode_jsconfig-json_react-jsx

Does this issue occur when all extensions are disabled?: Yes
@mjbvz mjbvz added this to the January 2021 milestone Dec 17, 2020
@mjbvz mjbvz added javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Dec 17, 2020
mjbvz added a commit to mjbvz/schemastore that referenced this issue Dec 17, 2020
@mjbvz
Add react-jsx to jsconfig jsx property
de72404 
Ports SchemaStore#1357 to the jsconfig schema

Fixes microsoft/vscode#112710
@mjbvz mjbvz mentioned this issue Dec 17, 2020
Merged
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Dec 17, 2020
madskristensen pushed a commit to SchemaStore/schemastore that referenced this issue Dec 18, 2020
@mjbvz
Add react-jsx to jsconfig jsx property (#1410)
c8960eb 
Ports #1357 to the jsconfig schema

Fixes microsoft/vscode#112710
@mjbvz
Copy link
Contributor

mjbvz commented Dec 18, 2020

Fixed by SchemaStore/schemastore#1410

@mjbvz mjbvz closed this as completed Dec 18, 2020
@connor4312 connor4312 added the verified Verification succeeded label Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

Successfully merging a pull request may close this issue.

Add react-jsx to jsconfig schema jsx property mjbvz/schemastore
3 participants
@mstssk @connor4312 @mjbvz