Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM64 .deb package code_1.52.0-1607640253_arm64 onwards contains 32-bit Intel 80386 keytar.node #113467

Closed
gjhoppy opened this issue Dec 27, 2020 · 7 comments
Closed

ARM64 .deb package code_1.52.0-1607640253_arm64 onwards contains 32-bit Intel 80386 keytar.node #113467

gjhoppy opened this issue Dec 27, 2020 · 7 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux verified Verification succeeded
Milestone
January 2021

Comments

@gjhoppy
Copy link

gjhoppy commented Dec 27, 2020

  • VSCode Version: 1.52.0-1607640253_
  • OS Version: Linux raspberrypi 5.4.79-v8+

Steps to Reproduce:

  1. Install and attempt to add a github token to the keychain
  2. This gives the error Writing login information to the keychain failed with error '/usr/share/code/resources/app/node_modules.asar.unpacked/keytar/build/Release/keytar.node: wrong ELF class: ELFCLASS32'
    4 Check the file type
    file keytar.node
    keytar.node: ELF 32-bit LSB pie executable, Intel 80386, version 1 (SYSV), dynamically linked, BuildID[sha1]=5297fc4f4077850c4730db5527ea7f40de21e038, stripped

Version 1.51 and previous builds have
file keytar.node
keytar.node: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=cd3b9cff00fad45345ae172d92b0a05012c8c2f2, not stripped

Does this issue occur when all extensions are disabled?: Yes
@sky-flix
Copy link

Version: 1.52.1
Commit: ea3859d
Date: 2020-12-16T16:31:12.802Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux arm64 5.8.0-25-generic

Can confirm that this error occurs on Ubuntu Hirsute Hippo for ARM as well.

@DMacMakes
Copy link

Same problem when I try to settings sync via my github account on Ubuntu Mate 20.10 aarch64, Pi 4b Rev 1.2

Version: 1.52.1
Commit: ea3859d
Date: 2020-12-16T16:31:12.802Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux arm64 5.8.0-1010-raspi

@Acees
Copy link

Acees commented Jan 5, 2021 •
edited
Loading

Same problem too, when I tried to sync my gists from github account on Manjaro KDE Plasma 20.12.1. My machine is Raspberry Pi 4B.

Version: 1.52.1
Commit: ea3859d
Date: 2020-12-16T16:31:12.802Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux arm64 5.4.83-1-MANJARO-ARM

Is this solved yet? Thanks!

@Tyriar Tyriar assigned joaomoreno and unassigned Tyriar Jan 6, 2021
@joaomoreno
Copy link
Member

So weird, it seems keytar is the only one:

➜  archs find . -name '*.node' | xargs file
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/keytar/build/Release/keytar.node:                          ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/spdlog/build/Release/spdlog.node:                          ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=79e66434515226cc13ad9ee6f153da1ce837a828, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/native-is-elevated/build/Release/iselevated.node:          ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=66c9609600956add52abe37ad87ad8e05b46b0cf, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/vscode-encrypt/build/Release/vscode-encrypt-native.node:   ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=7057f9476a6ff6d6c2c548294c1fad7611bda125, with debug_info, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/vsda/build/Release/vsda.node:                              ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=17bfe6f30fec39e3bb5069ce96a807c7bded2315, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/node-pty/build/Release/pty.node:                           ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=dbf5c95305e07dc3b44c38bd92e6149943e5c869, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/native-watchdog/build/Release/watchdog.node:               ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=8b7281451991f813f2e5515b86c3ac2433fb9dc5, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/native-keymap/build/Release/keymapping.node:               ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=0dbe96b94dbeaabaa50723e06b4961269ede6d21, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/vscode-sqlite3/build/Release/sqlite.node:                  ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=82ca1a9cfd961f8a51d6226ca2326d4ae7b5fe40, not stripped
./VSCode-linux-x64/resources/app/node_modules.asar.unpacked/vscode-nsfw/build/Release/nsfw.node:                       ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=ebf10b7f37d02e129b35c6362b395bcdde641eb8, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/keytar/build/Release/keytar.node:                        ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), dynamically linked, BuildID[sha1]=5297fc4f4077850c4730db5527ea7f40de21e038, stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/spdlog/build/Release/spdlog.node:                        ELF 64-bit LSB shared object, ARM aarch64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=b3c3bc4183e4831a1214e77b3f4cc15ceda6e2fc, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/native-is-elevated/build/Release/iselevated.node:        ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=bcdf56a4adef3d2f90aa66e415117f207abcd5c9, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/vscode-encrypt/build/Release/vscode-encrypt-native.node: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=411f02c31b09c965f83df6ca59a800aac17131d6, with debug_info, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/vsda/build/Release/vsda.node:                            ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=882e2d8abd75ade35274a9128387bf9b45fe97f2, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/node-pty/build/Release/pty.node:                         ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=f8c33aadd5b48f2c213301dcfe053d8d6aa78d65, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/native-watchdog/build/Release/watchdog.node:             ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=e2041b2123a5f8a3cc31c5a227be0f3f01c2ef78, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/native-keymap/build/Release/keymapping.node:             ELF 64-bit LSB shared object, ARM aarch64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=a5c2a3faf254f95a513ef99d57471b59f8e7603b, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/vscode-sqlite3/build/Release/sqlite.node:                ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=dcccb9ce6cb8ee2381bf5771fecce5511d452a38, not stripped
./VSCode-linux-arm64/resources/app/node_modules.asar.unpacked/vscode-nsfw/build/Release/nsfw.node:                     ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=5b49ed819f209225dd8303da1ac8ebc13619888f, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/keytar/build/Release/obj.target/keytar.node:             ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=54993d2b8de866c2d90a3d1ecb69e76d5ba1d523, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/keytar/build/Release/keytar.node:                        ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=54993d2b8de866c2d90a3d1ecb69e76d5ba1d523, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/spdlog/build/Release/spdlog.node:                        ELF 32-bit LSB shared object, ARM, EABI5 version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=c5c3f2ef92bf69e055678f6406162f466ec67ecd, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/native-is-elevated/build/Release/iselevated.node:        ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=628e0743371f036a932b424cc2937c777e8e8a9a, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/vscode-encrypt/build/Release/vscode-encrypt-native.node: ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=756aac140bbfdcba597a9c9d6e764841d6e06211, with debug_info, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/vsda/build/Release/vsda.node:                            ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=01be4c3d0321b4725197477c4d33b872d74a07f4, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/node-pty/build/Release/pty.node:                         ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=0698ea68c85d9f8336060d8319d402f98aadc1e3, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/native-watchdog/build/Release/watchdog.node:             ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=315fac3a32031600644e35719e2878b874632c86, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/native-keymap/build/Release/keymapping.node:             ELF 32-bit LSB shared object, ARM, EABI5 version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=ed0539deb76f3c06321f818ace638ff7f25d6a38, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/vscode-sqlite3/build/Release/sqlite.node:                ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=ad6b5221c0f86f313ef92e96cceb38a0489935a0, not stripped
./VSCode-linux-armhf/resources/app/node_modules.asar.unpacked/vscode-nsfw/build/Release/nsfw.node:                     ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=1e523ca4b0856f64e828b8f09860e6327c7ecb8d, not stripped

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux labels Jan 7, 2021
@joaomoreno joaomoreno added this to the January 2021 milestone Jan 7, 2021
joaomoreno added a commit that referenced this issue Jan 27, 2021
@joaomoreno
fixes #113467
e894045
@joaomoreno joaomoreno mentioned this issue Jan 27, 2021
Closed
@joaomoreno
Copy link
Member

Upstream issue: atom/node-keytar#347

@joaomoreno joaomoreno mentioned this issue Jan 28, 2021
Closed
@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Jan 28, 2021
@github-actions
Copy link

This bug has been fixed in to the latest release of VS Code Insiders!

@gjhoppy, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version 2ce2664 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@gjhoppy
Copy link
Author

gjhoppy commented Jan 28, 2021 •
edited
Loading

All working as expected thanks

/verified

@JacksonKearl JacksonKearl added the verified Verification succeeded label Jan 29, 2021
plainerman pushed a commit to plainerman/vscode that referenced this issue Feb 2, 2021
@joaomoreno @plainerman
Squashed commit of the following:
aa30d7f 
commit 36f3d9d
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Thu Jan 28 13:23:23 2021 +0100

    npx

commit 8ccb45e
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Thu Jan 28 12:52:15 2021 +0100

    bump cache salt

commit 5f5d6b1
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Thu Jan 28 11:39:32 2021 +0100

    force rebuild keytar

commit a5f800f
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Wed Jan 27 16:16:05 2021 +0100

    bump cache salt

commit e894045
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Wed Jan 27 16:15:24 2021 +0100

    fixes microsoft#113467
MarcoZehe pushed a commit to MarcoZehe/vscode that referenced this issue Feb 3, 2021
@joaomoreno @MarcoZehe
Squashed commit of the following:
725b09e 
commit 36f3d9d
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Thu Jan 28 13:23:23 2021 +0100

    npx

commit 8ccb45e
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Thu Jan 28 12:52:15 2021 +0100

    bump cache salt

commit 5f5d6b1
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Thu Jan 28 11:39:32 2021 +0100

    force rebuild keytar

commit a5f800f
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Wed Jan 27 16:16:05 2021 +0100

    bump cache salt

commit e894045
Author: João Moreno <joao.moreno@microsoft.com>
Date:   Wed Jan 27 16:15:24 2021 +0100

    fixes microsoft#113467
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
9 participants
@joaomoreno @Tyriar @gjhoppy @sky-flix @rzhao271 @JacksonKearl @Acees @DMacMakes and others