New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook outputs api #115817
notebook outputs api #115817
Conversation
…ext output inside the ext host)
This reverts commit 8522c22.
@jrieken @roblourens export class NotebookCellOutputItem {
readonly metadata?: Record<string, string | number | boolean>;
} The metadata only supports a flat keyvalue pair. However We don't control the metadata returned by Jupyter and it could (we don't know) contain complex data. |
TODOs:
CellOutput
and the newNotebookCellOutput
are converted toIOutputDtoWithId
before transferred to main thread.CellOutputViewModel
holds reference to the raw output and also the transformed one (stream
to{ 'application/x-notebook-stream': '' )
.ITransformedDisplayOutputDto
, which hasoutputId
and[mimeType: string]: any
.NotebookCell.outputs2: NotebookCellOutput[]
{ id: string;outputs: NotebookCellOutputItem[]; }
)NotebookCellOutput
objects in extension host.NotebookCell.outputs: ICellOutput[]