Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Unable to bypass ssl verification any more for corp firewall #11702

Closed
ericanderson opened this issue Sep 8, 2016 · 14 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded

Comments

@ericanderson
Copy link

  • VSCode Version: 1.5
  • OS Version: 10.11.6

Steps to Reproduce:

  1. Install a transparent man-in-the-middle firewall with a self signed cert and be sure that all traffic is being intercepted.
  2. Install VSCode 1.4.
  3. Notice that VSCode can't update extensions due to MITM.
  4. Set http.proxyStrictSSL=false
  5. Notice that VSCode can now update extensions or search extensions, etc.
  6. Upgrade to 1.5
  7. Notice that VSCode can no longer speak to the internet when trying to search for an extension
@mderriey
Copy link

mderriey commented Sep 8, 2016

The same issue happens to me after updating to 1.5. Using Windows 7 SP1.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Sep 9, 2016
@joaomoreno joaomoreno added this to the August Recovery 2016 milestone Sep 9, 2016
@joaomoreno
Copy link
Member

@ericanderson Can you show me how I can do step 1?

Install a transparent man-in-the-middle firewall with a self signed cert and be sure that all traffic is being intercepted.

This has been the major problem in fixing proxy issues: I don't know how to reproduce all these scenarios.

@ghost
Copy link

ghost commented Sep 9, 2016

@joaomoreno The same issue is reproduced with http/https proxies with self-signed certificates, I also reproduce this issue in our corporate network since the update.

@joaomoreno
Copy link
Member

Awesome, was able to reproduce this using Charles. Will definitely buy this to keep the proxy issues in control.

joaomoreno added a commit that referenced this issue Sep 9, 2016
@joaomoreno
Copy link
Member

Found the issue, pushed to master. Will try to get it into a recovery build asap.

@mderriey
Copy link

mderriey commented Sep 9, 2016

Thanks for being so responsive! Keep up the good work!

@darron-haworth
Copy link

Thank you for the update! 👍

@seanmcbreen
Copy link

While we wait for a broad update you can use Insiders to work around this...
http://code.visualstudio.com/insiders

@joaomoreno
Copy link
Member

@seanmcbreen The latest insiders doesn't have the fix yet, since last build happened Friday morning (CET). I'm triggering new insider builds and releasing them, so people get it.

@joaomoreno
Copy link
Member

Verification: use Charles to proxy SSL requests to/from https://marketplace.visualstudio.com/. Set up Code to use Charles as a proxy and setstrictSSLtofalse`.

@dbaeumer dbaeumer added the verified Verification succeeded label Sep 12, 2016
@sbromberger
Copy link

sbromberger commented Sep 12, 2016

Just wanted to say - bravo and many thanks for the quick fix!! 👍

Oh yeah - confirmed fixed on OSX 10.11.6.

@mrichman
Copy link

Confirm fixed on Windows 10.

@mderriey
Copy link

Thanks for fixing this so quickly and getting it out in a matter of days!

@joaomoreno
Copy link
Member

Thanks for the confirmation guys.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants