+ button and context menu for terminal tabs #120878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Apr 8, 2021
Tyriar
reviewed
Apr 9, 2021
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
|
Adding lots of terminals ends up pushing the button out and the tree doesn't fit the whole height
|
Tyriar
requested changes
Apr 9, 2021
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Apr 12, 2021
meganrogge
commented
Apr 12, 2021
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
Tyriar
requested changes
Apr 13, 2021
src/vs/workbench/contrib/terminal/browser/terminalTabsWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabsWidget.ts
Outdated
Show resolved
Hide resolved
meganrogge
force-pushed
the
merogge/tabs-button
branch
from
b98c5aa
to
7123044
Compare
Tyriar
approved these changes
Apr 13, 2021
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalTabsWidget.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
auto-merge was automatically disabled
April 13, 2021 22:21
Rebase failed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.