-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On PC 'Delete' key not working on insiders for approx last week #123040
Comments
(Experimental duplicate detection) |
Does the problem also happen when all your extensions are disabled? Maybe use the "Start Extension Bisect" command in order to investigate. |
Giving this a go now. |
I have disabled all of the extensions and the delete key is still poping up the "Cannot read property 'dispose' of undefined" in the edit window and does not remove breakpoints. Is it working for you on Windows? |
Can you run "Developer: Toggle Keyboard Shortcuts Troubleshooting" and include the logs it generates concerning how the delete key is being handled? |
Here's mine when I press the delete key: [2021-05-06 14:44:43.466] [renderer1] [info] [KeybindingService]: / Received keydown event - modifiers: [], code: Delete, keyCode: 46, key: Delete I guess that's from wrong key bindings, right? I could manage to correct the problem myself but why did this happen?
|
@feeva I presume you did not have the terminal tabs tree focused at that time? cc @meganrogge are the context keys maybe being incorrectly set? |
@JacksonKearl I removed the key binding. So now I don't know that for sure. Do you still need to know? |
It would be helpful for debugging to know if your focus was in on the terminal tabs view, in which case running This problem is appearing now because terminal tabs are a new feature with this iteration. |
Ah, yeah, the new terminal tabs. I like it anyway. 👍 My focus was in the editor. I was just doing normal edit activities. But I'm not sure the terminal was open or not. |
Plot thickens, when I first run the "Developer: Toggle Keyboard Shortcuts Troubleshooting" command I get the following error as I have deleted the initial powershell terminal as I use the "javascript Debug Terminal" as my default. [2021-05-06 12:32:18.733] [renderer1] [error] Terminal with ID 1 does not exist (has it already been disposed?): Error: Terminal with ID 1 does not exist (has it already been disposed?) |
The log when I press the delete key with the focus in the edit window is: [2021-05-06 16:30:11.937] [renderer1] [info] [KeybindingService]: / Received keydown event - modifiers: [], code: Delete, keyCode: 46, key: Delete |
The log when I press the delete key with the focus in the breakpoint window and press the delete key after selecting a breakpoint via the mouse: |
More details:
I did the following:
I also did the following
|
Let me know if I can do anything more. |
I've encountered the same issue with the delete key. It started working after I removed following binding: |
Yet more info: |
Just updated to 1.56.0 and the delete key stopped working. This is the log from pressing delete:
Removing the About info: |
All shortcuts using Version: 1.56.0 |
Are people experiencing this all using the new terminal tabs, or is it happening with tabs disabled? |
@Tyriar, It also happens when Terminal Tabs are disabled. When the editor is in focus, if you hit DELETE, it switches focus to the Terminal. |
@Tyriar, I have kinda the same issue and it happens until I disable tabs and restart VScode. |
I can confirm that I deleted the PowerShell terminal, and that is when the delete key stopped working. Adding a PowerShell terminal back made it work again. |
Have this on the update I received today. After updating but before restarting, default terminals started disappearing from the terminal picker until I had only two "Ubuntu (WSL)" there, why there were two of those I don't know either. Additionally terminal titles seem to not be dynamic regardless of the setting of overrideName or even when "terminal.integrated.profiles.{platform}" is removed completely. I update, restart vs code Resolution requires disabling terminal tabs and restarting vs code again Ironically the del key appears to work in the terminal 🤣 |
Not totally clear what you mean here, could you create a gif in a new issue?
Tracked in #123104 |
I have tested it on the following version and my reported del key problem is now fixed. Version: 1.57.0-insider (user setup) |
Hey thanks so much, we intend to close this issue w the PR headed for the release branch of stable on Tuesday, so will keep it open until then @acotty |
I did not think about the 1.56.x release branch... I know if there is a next time for a bug I raise. |
I'm having this issue with the latest release, is there anything I can do to resolve this issue? Version: 1.56.1 (user setup) |
@Lycolia 1.56.2 is coming soon which will have this fixed |
On Windows 10 with insiders for the last 5 to 7 days the delete key has been doing "funny" things like and the issues have changed, but still does not work correctly.
The delete key works fine in all other windows apps, so the physical keyboad is okay.
If you need logs or anything else please let me know and I will try to supply the data/info ASAP.
Version: 1.57.0-insider (user setup)
Commit: b95b73b
Date: 2021-05-05T17:20:18.311Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19042
The text was updated successfully, but these errors were encountered: