Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Item shouldn't propose an item already present in the list #127414

Closed
dbaeumer opened this issue Jun 29, 2021 · 4 comments
Closed

Add Item shouldn't propose an item already present in the list #127414

dbaeumer opened this issue Jun 29, 2021 · 4 comments
Assignees
@rzhao271
Labels
*duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues

Comments

@dbaeumer
Copy link
Member

Testing #127176

capture
@dbaeumer
Copy link
Member Author

Same when editing an item

capture

@stevencl
Copy link
Member

Agreed. It shouldn't be possible to get to this state:
image

Shouldn't this just be three checkboxes, one for each option?

@rzhao271
Copy link
Contributor

The order of the items matters for this setting. Something I plan on doing is adding up/down buttons to the side next to the edit button, which users can use to rearrange the items. Afterwards, I can change the proposals to not repeat.
Otherwise, rendering the items as a list of checkboxes works.

@rzhao271
Copy link
Contributor

rzhao271 commented Jul 6, 2021

Closing in favour of #127424.

@rzhao271 rzhao271 closed this as completed Jul 6, 2021
@rzhao271 rzhao271 added *duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues labels Jul 6, 2021
@rzhao271 rzhao271 mentioned this issue Jul 16, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
*duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevencl @dbaeumer @rzhao271