Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal is tiny when extensions create and show them #128342

Closed
SoumadeepChoudhury opened this issue Jul 9, 2021 · 25 comments
Closed

Terminal is tiny when extensions create and show them #128342

SoumadeepChoudhury opened this issue Jul 9, 2021 · 25 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded

Comments

@SoumadeepChoudhury
Copy link

Issue Type: Bug

I am facing an issue with the terminal window in VS Code.
The first time I open the terminal window or I run a program snippet it works seamlessly fine but on the next Run the terminal window freezes( only showing colon at the end of the terminal window and nothing else).
I am facing this problem after the recent update to 1.58 ...
Please fix his problem as soon as possible.

VS Code version: Code 1.58.0 (2d23c42, 2021-07-08T06:54:55.083Z)
OS version: Windows_NT x64 10.0.17763
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Pentium(R) CPU G3220 @ 3.00GHz (2 x 2993)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: disabled_off
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 3.87GB (0.54GB free)
Process Argv --crash-reporter-id 60c62695-e077-4632-943b-c0148c3dc4f1
Screen Reader no
VM 0%
Extensions (11)
Extension Author (truncated) Version
fluent-icons mig 0.0.12
python ms- 2021.6.944021595
vscode-pylance ms- 2021.7.2
jupyter ms- 2021.8.1013163132
java red 0.64.1
vscodeintellicode Vis 1.2.14
vscode-java-debug vsc 0.34.0
vscode-java-dependency vsc 0.18.5
vscode-java-pack vsc 0.17.0
vscode-java-test vsc 0.30.1
vscode-maven vsc 0.31.0
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspyt653:30270858
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30335481
vscorehov:30309549
vscod805:30301674
pythonvspyt200:30331937
vscextlangct:30333562
binariesv615:30325510
vstea450:30335276
bridge0708:30335490

image

@meganrogge
Copy link
Contributor

Please attach a gif of this happening.

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Jul 9, 2021
@SoumadeepChoudhury
Copy link
Author

Please attach a gif of this happening.

Here's the clip.

Issue.mp4

@healertrix
Copy link

facing even worse issue mine is showing nothing 😥
Capture

@starryskyegg
Copy link

The very first run is fine.
The second run will be all black (with some texts flashing at the bottom of terminal), and texts can manifest after ctrl++, ctrl+- or switching to other pages and switching to terminal again. If scrolling up, the originally expected texts will show on the top in a weird format (in a row?). So, actually the outputs are printed twice.
Facing this bug after updating to ver.1.58, too

Video_2021-07-11_001354.mp4

@Sam-Varghese
Copy link

Sam-Varghese commented Jul 10, 2021

Hey folks, Sam Varghese here. I am also facing this issue after VSCode got updated. I even raised a query at the stack overflow regarding this. Here is a link to the question I raised: https://stackoverflow.com/q/68328179/15446699 From there I came to know that an issue regarding this has been raised, thanks to SoumadeepChoudhury. I have also recorded my screen in order to show the problem I am facing. Here is it:

vedio.mp4

I use windows 10 and updating VSCode made my terminal behave so weirdly as shown above.

Hope this problem gets sorted out as soon as possible

@kartikeyporwal
Copy link

I too am experiencing this very similar issue since the time I updated my VS Code to version 1.58.0 on Ubuntu 20.04.2 LTS yesterday, I can't see the terminal content, on top of that, sometimes, I can't kill the terminal using the icon on the terminal's right side.
I am opening and closing the terminal multiple time using CTRL+ ` and reloading VS Code as a workaround to deal with these 2 issues.

@comiluv
Copy link

comiluv commented Jul 11, 2021

I am getting this problem as well since upgrading to 1.58.0
I currently rolled back my installation of VSCode to version 1.57.1 which you can do as well by going to this link: https://code.visualstudio.com/updates/v1_57

@Sam-Varghese
Copy link

We can get rid of this problem by firstly running the Toggle Panel command, and then running our programs.

2.mp4

Because I have noticed that this problem occurs only when we don't have our terminal already opened. So opening the terminal via the Toggle Panel command could help us eliminate this problem.

@SoumadeepChoudhury
Copy link
Author

We can get rid of this problem by firstly running the Toggle Panel command, and then running our programs.

2.mp4
Because I have noticed that this problem occurs only when we don't have our terminal already opened. So opening the terminal via the Toggle Panel command could help us eliminate this problem.

Thank You Sam Varghese a lot for getting a great fix about this problem. Yet I hope Microsoft Team fixes this issue properly & universally anon so that we can use VS Code as previously before the recent update to 1.58.

@Sam-Varghese
Copy link

You're welcome, happy this solution helped 😊

@healertrix
Copy link

no dude it isnt working for me ,they really broke the terminal in the latest update

@meganrogge meganrogge removed the info-needed Issue requires more information from poster label Jul 12, 2021
@Sam-Varghese
Copy link

no dude it isnt working for me ,they really broke the terminal in the latest update

So that means even the Toggle Panel command shows you a blank terminal?

@healertrix
Copy link

unfortunately yes, but how are these ppl closing the issue without even trying to solve our problem

@Tyriar
Copy link
Member

Tyriar commented Jul 13, 2021

Adding to recovery to investigate, I think it's related to #128255 and #128264

@Tyriar Tyriar added this to the June 2021 Recovery 2 milestone Jul 13, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Jul 13, 2021
@healertrix
Copy link

yes its still blank

@korstiaanS
Copy link

Upgrade to 1.58.1 did not help.

@Tyriar
Copy link
Member

Tyriar commented Jul 14, 2021

Can repro:

  1. Install python extension
  2. Open test.py that has contents print('abc')
  3. Run the file
  4. Type exit
  5. Run the file, the terminal will run but it will be really tiny:

image

@Tyriar
Copy link
Member

Tyriar commented Jul 14, 2021

Root cause is the terminal is initialized with 0x0 dimensions

image

@Tyriar
Copy link
Member

Tyriar commented Jul 14, 2021

Repro with terminal-sample:

  1. Open window without terminal showing
  2. Run Terminal API: Create Terminal
  3. Run Terminal API: Show, it works
  4. Close it with the bin icon
  5. Run Terminal API: Create Terminal
  6. Run Terminal API: Show, the terminal will be 2x1

Repro 2 which should also be validated:

  1. Open window without terminal showing
  2. Run Terminal API: Create Terminal
  3. Run Terminal API: Show, it works
  4. Split the terminal
  5. Close the terminal (not kill)
  6. Run Terminal API: Create Terminal
  7. Run Terminal API: Show and select the new terminal, it will be 2x1 - ensure also that the dimensions of the terminal fill the terminal panel

@Tyriar Tyriar changed the title Issue with TERMINAL WINDOW. Terminal is tiny when extensions create and show them Jul 14, 2021
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Jul 14, 2021
Tyriar added a commit that referenced this issue Jul 14, 2021
This fixes an issue where when the terminal would be created without a container
it initializes with 0x0 dimensions which gets set to the minimum of 2x1 instead
of the expected default of 80x30 (which node-pty respects). This 80x30 is now
hardcoded in VS Code.

Fixes #128342
@Tyriar Tyriar closed this as completed in 1c3aaf8 Jul 14, 2021
@meganrogge
Copy link
Contributor

meganrogge commented Jul 15, 2021

@Tyriar the terminal is now less tiny, but the cursor is in the wrong position 🤔
UPDATE: cursor is positioned correctly when window is expanded

recording (32)

@meganrogge meganrogge added the verified Verification succeeded label Jul 15, 2021
@Tyriar
Copy link
Member

Tyriar commented Jul 15, 2021

@meganrogge i think this is as expected, when shown it will change from 80x30 to smaller which will end up getting resized by conpty and sometimes it acts up

@Sam-Varghese
Copy link

Today my VSCode got updated and all issues that I was facing with the terminal got solved.

Thank you very much Meganrogge and Tyriar for solving all issues with the terminal so fast.

@SoumadeepChoudhury
Copy link
Author

Today my VSCode got updated and all issues that I was facing with the terminal got solved.

Thank you very much Meganrogge and Tyriar for solving all issues with the terminal so fast.

I too got an update to 1.58.2 and all the problems regarding the terminal are fixed, Thanks Megan Rogge and Tyriar for the greater help and look out at our issue.

@MokshitSurana
Copy link

Thank you guys, my issue also got resolved by updating to 1.58.2. Megan and Tyriar you guys are great 💯

@healertrix
Copy link

healertrix commented Aug 2, 2021

mine still hasnt worked
i am currently using windows terminal pls sort my problem asap
im using latest vscode update

this problem arised when i tried to change font of my terminal and since then its been blank

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2021
jeanp413 added a commit to jeanp413/vscode that referenced this issue Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

11 participants