Upgrade to VS Code 1.58.2

[akosyakov]

What it does

fix #4626 It upgrades VS Code to 1.58.2.

How to test

Test following aspects:

• terminals are preserved and resized properly between window reloads
• extension host process: check language smartness
• extension management (installing/uninstalling)
  • install VIM extension to test web extensions
• gp open and preview
• that user data are sync across workspaces as well as on workspace restart, especially for extensions
  • test that extensions from .gitpod.yml are installed without sync
• workspace specific commands should work, i.e. F1 → type Gitpod prefix
• that a PR view is preloaded on the PR url
• websockets and workers are properly proxied
  • diff editor should be operatable
  • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount
• settings should not contain any mentions of MS telemetry
• smoke test on Chrome, FF, and Safari on Mac/iPad

[codecov]

Codecov Report

Merging #4807 (46e851b) into main (4bb8d42) will increase coverage by 37.78%.
The diff coverage is n/a.

❗ Current head 46e851b differs from pull request most recent head 158fd50. Consider uploading reports for the commit 158fd50 to get more accurate results

@@            Coverage Diff            @@
##           main    #4807       +/-   ##
=========================================
+ Coverage      0   37.78%   +37.78%     
=========================================
  Files         0       50       +50     
  Lines         0     9741     +9741     
=========================================
+ Hits          0     3681     +3681     
- Misses        0     5768     +5768     
- Partials      0      292      +292     

Flag	Coverage Δ
components-gitpod-cli-app	9.74% <ø> (?)
components-supervisor-app	36.04% <ø> (?)
components-ws-manager-app	36.77% <ø> (?)
components-ws-proxy-app	67.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/gitpod-cli/cmd/sync-await.go	10.52% <0.00%> (ø)
components/supervisor/pkg/terminal/service.go	29.09% <0.00%> (ø)
components/supervisor/pkg/supervisor/git.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go	0.00% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go	74.46% <0.00%> (ø)
components/gitpod-cli/cmd/url.go	36.36% <0.00%> (ø)
components/ws-proxy/pkg/proxy/auth.go	100.00% <0.00%> (ø)
components/supervisor/pkg/ports/tunnel.go	63.63% <0.00%> (ø)
components/ws-proxy/pkg/proxy/pass.go	76.85% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go	0.00% <0.00%> (ø)
... and 40 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb8d42...158fd50. Read the comment docs.

[akosyakov]

Generally everything wokrs alright, but terminals need to be resized sometimes to show content. It is known a bug: microsoft/vscode#128342 and scheduled for the recovery release.

[akosyakov]

1.58.2 is out with terminal fixes, going to rebase again today

[akosyakov]

/assign @corneliusludmann

[akosyakov]

/hold

[akosyakov]

It looks good now and contain latest recovery release. @corneliusludmann You can test it already. #4738 is almost ready too.

[akosyakov]

/unhold

[corneliusludmann]

/werft run

👍 started the job as gitpod-build-akosyakov-code-upgrade-to-4626.3

[corneliusludmann]

Anton: I took the liberty to rebase this branch on main to get a running preview env (see #4867).

[corneliusludmann]

When I open a pull request, the PR view is not loaded. When try to open the PR view I see these logs:

[Info] /home/gitpod/.ssh/config: ENOENT: no such file or directory, open '/home/gitpod/.ssh/config'
[Info] Registering git provider
[Info] Looking for git repository
[Info] Found 1 repositories during activation
[Info] Git repository found, initializing review manager and pr tree view.
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] No remote with name 'upstream' found.
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch akosyakov/code-upgrade-to-4626
[Info] Review> no matching pull request metadata found on GitHub for current branch akosyakov/code-upgrade-to-4626

[corneliusludmann]

Everything else looks good so far.

[akosyakov]

Could you check please whether it is not
the same in production? It could be a regression in a new version of GHPR extension not in VS Code

[corneliusludmann]

In production, it works.

[akosyakov]

/werft run

👍 started the job as gitpod-build-akosyakov-code-upgrade-to-4626.10

[akosyakov]

@corneliusludmann it worked for me:

Maybe there is a confusion: GHPR only works if you allowed it to access a token. There is the account menu in the left bottom corner. It should not have any notifications. If it has then you should click on it and grant access. After that you have to start a new workspace. We actually have an issue to make it more prominent: #4081

[corneliusludmann]

Thanks for the hint, Anton. Now it works.

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 6319fb6caa46d649c674c515bba9e4612bdf7ae9

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, corneliusludmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/ide/OWNERS [akosyakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment