Add terminal profile smoke tests #137079
Merged
Add terminal profile smoke tests #137079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Nov 12, 2021
meganrogge
commented
Nov 12, 2021
Closed
meganrogge
commented
Nov 16, 2021
meganrogge
commented
Nov 16, 2021
meganrogge
force-pushed
the
merogge/shadow
branch
from
e5cbaee
to
71f765f
Compare
On WebKit the smoke tests were failing because the quick pick was triggering a focus event on the terminal after the blur event had already happened, this caused the view service to think the terminal was still focused when it wasn't. The fix was to reset the context key also in IViewsService.closeView.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137360
Part of #136064