Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 15: UnhandledPromiseRejectionWarning in extensions/emmet/test-workspace integration tests #137416

Closed
deepak1556 opened this issue Nov 18, 2021 · 1 comment
Closed

Electron 15: UnhandledPromiseRejectionWarning in extensions/emmet/test-workspace integration tests #137416

deepak1556 opened this issue Nov 18, 2021 · 1 comment
Assignees
@bpasero
Labels
debt Code quality issues electron-16-update Issues related to electron 16 update
Projects
Electron Integration
Milestone
November 2021

Comments

@deepak1556
Copy link
Contributor

Steps to Reproduce:

1) git co electron-16.x.y
2) yarn && yarn watch
3) scripts/test-integration.sh

(node:10567) UnhandledPromiseRejectionWarning: Canceled: Canceled
    at canceled (/Users/demohan/github/vscode/out/vs/base/common/errors.js:109:23)
    at Delayer.cancel (/Users/demohan/github/vscode/out/vs/base/common/async.js:247:57)
    at Delayer.dispose (/Users/demohan/github/vscode/out/vs/base/common/async.js:259:18)
    at ThrottledDelayer.dispose (/Users/demohan/github/vscode/out/vs/base/common/async.js:287:26)
    at dispose (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:99:27)
    at DisposableStore.clear (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:160:17)
    at DisposableStore.dispose (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:153:18)
    at FileWatcher.dispose (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:195:25)
    at FileWatcher.dispose (/Users/demohan/github/vscode/out/vs/platform/files/node/watcher/nodejs/watcherService.js:103:19)
    at dispose (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:99:27)
    at DisposableStore.clear (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:160:17)
    at DisposableStore.dispose (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:153:18)
    at dispose (/Users/demohan/github/vscode/out/vs/base/common/lifecycle.js:115:17)
    at DiskFileSystemProviderChannel.unwatch (/Users/demohan/github/vscode/out/vs/platform/files/node/diskFileSystemProviderIpc.js:158:41)
    at DiskFileSystemProviderChannel.call (/Users/demohan/github/vscode/out/vs/platform/files/node/diskFileSystemProviderIpc.js:39:45)
    at ChannelServer.onPromise (/Users/demohan/github/vscode/out/vs/base/parts/ipc/common/ipc.js:259:35)
    at ChannelServer.onRawMessage (/Users/demohan/github/vscode/out/vs/base/parts/ipc/common/ipc.js:232:33)
    at /Users/demohan/github/vscode/out/vs/base/parts/ipc/common/ipc.js:177:73
    at Emitter.fire (/Users/demohan/github/vscode/out/vs/base/common/event.js:435:38)
    at /Users/demohan/github/vscode/out/vs/base/common/event.js:43:93
    at Emitter.fire (/Users/demohan/github/vscode/out/vs/base/common/event.js:435:38)
    at /Users/demohan/github/vscode/out/vs/base/common/event.js:54:106
    at Emitter.fire (/Users/demohan/github/vscode/out/vs/base/common/event.js:435:38)
    at IpcMainImpl.fn (/Users/demohan/github/vscode/out/vs/base/common/event.js:237:44)
    at IpcMainImpl.emit (node:events:394:28)
    at Object.<anonymous> (node:electron/js2c/browser_init:161:9959)
    at Object.emit (node:events:394:28)
(Use `Electron --trace-warnings ...` to show where the warning was created)
(node:10567) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
@deepak1556
Copy link
Contributor Author

deepak1556 commented Nov 18, 2021 •
edited
Loading

@bpasero I am assigning it to you as a start since the trace has file watcher paths.

/cc @rzhao271 for emmet component

@bpasero bpasero added this to the November 2021 milestone Nov 18, 2021
@bpasero bpasero added this to ✨ New in Electron Integration Nov 18, 2021
@deepak1556 deepak1556 added electron-16-update Issues related to electron 16 update and removed electron-15-update labels Nov 18, 2021
@bpasero bpasero moved this from ✨ New to 🏃 In Progress in Electron Integration Nov 18, 2021
bpasero added a commit that referenced this issue Nov 18, 2021
@bpasero
watcher - fix unhandled rejection (fix #137416)
c8081d8
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 18, 2021
@bpasero bpasero closed this as completed Nov 18, 2021
deepak1556 pushed a commit that referenced this issue Nov 19, 2021
@bpasero @deepak1556
watcher - fix unhandled rejection (fix #137416)
87b312d
@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Nov 20, 2021
@bpasero bpasero moved this from 🏃 In Progress to ✔️ Done / Deferred in Electron Integration Dec 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2022
bpasero added a commit that referenced this issue Feb 8, 2022
@deepak1556 @bpasero @rzhao271
chore: update to electron 16 (#137241)
01df559 
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488d.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af26148.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs #137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs electron/electron@797723e

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs #137659

* ci: switch to buster for linux arm

Refs #137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes #138792
Fixes #139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs #137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@deepak1556 @bpasero @rzhao271
chore: update to electron 16 (microsoft#137241)
0d9f392 
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488d.

* Revert "watcher - enable crash reports on linux (microsoft#136264)"

This reverts commit af26148.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix microsoft#137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs microsoft#137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs electron/electron@797723e

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs microsoft#137659

* ci: switch to buster for linux arm

Refs microsoft#137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs microsoft#137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (microsoft#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes microsoft#138792
Fixes microsoft#139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs microsoft#137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@deepak1556 @bpasero @rzhao271
chore: update to electron 16 (microsoft#137241)
9f0ddd0 
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488d.

* Revert "watcher - enable crash reports on linux (microsoft#136264)"

This reverts commit af26148.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix microsoft#137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs microsoft#137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs electron/electron@797723e

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs microsoft#137659

* ci: switch to buster for linux arm

Refs microsoft#137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs microsoft#137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (microsoft#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes microsoft#138792
Fixes microsoft#139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs microsoft#137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@deepak1556 @bpasero @rzhao271
chore: update to electron 16 (microsoft#137241)
d783f3e 
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488d.

* Revert "watcher - enable crash reports on linux (microsoft#136264)"

This reverts commit af26148.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix microsoft#137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs microsoft#137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs electron/electron@797723e

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs microsoft#137659

* ci: switch to buster for linux arm

Refs microsoft#137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs microsoft#137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (microsoft#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes microsoft#138792
Fixes microsoft#139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs microsoft#137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues electron-16-update Issues related to electron 16 update
Projects
VSCode Electron Integration
Archived in project
Electron Integration
  
✔️ Done / Deferred
Milestone
November 2021
Development

No branches or pull requests
2 participants
@bpasero @deepak1556