Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental dark mode flag #139109

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Add experimental dark mode flag #139109

merged 2 commits into from
Dec 16, 2021

Conversation

rzhao271
Copy link
Contributor

Ref #84453

With the experimental dark mode flag + Electron 16, native titlebars for VS Code on Windows now match with both light mode and dark mode system themes.

Screenshot from custom build:
Example

@rzhao271 rzhao271 added this to the January 2022 milestone Dec 14, 2021
@rzhao271 rzhao271 self-assigned this Dec 14, 2021
@rzhao271 rzhao271 marked this pull request as ready for review December 14, 2021 17:14
bpasero
bpasero requested changes Dec 14, 2021
View reviewed changes
src/vs/platform/native/electron-main/nativeHostMainService.ts Outdated Show resolved Hide resolved
build/builtin/main.js Outdated Show resolved Hide resolved
src/vs/platform/issue/electron-main/issueMainService.ts Outdated Show resolved Hide resolved
src/vs/platform/windows/electron-main/window.ts Outdated Show resolved Hide resolved
bpasero
bpasero approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this window option temporary or why do we have to enable it explicitly? And what is the impact of the flag specifically?

And can the user override this?

@rzhao271
Copy link
Contributor Author

Is this window option temporary or why do we have to enable it explicitly? And what is the impact of the flag specifically?

And can the user override this?

Resolved offline.

@deepak1556 deepak1556 merged commit 0a4b134 into electron-16.x.y Dec 16, 2021
@deepak1556 deepak1556 deleted the rzhao271/dark-mode-16 branch December 16, 2021 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@bpasero bpasero bpasero approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
January 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@rzhao271 @bpasero @deepak1556 @raghavthind2005