Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sequence for PS2 for commands containing line breaks #140665

Closed
Tyriar opened this issue Jan 13, 2022 · 1 comment
Closed

Support sequence for PS2 for commands containing line breaks #140665

Tyriar opened this issue Jan 13, 2022 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
February 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 13, 2022 •
edited

Shift+enter on pwsh caused this:

Screen Shot 2022-01-13 at 12 50 34 pm

Screen Shot 2022-01-13 at 12 51 01 pm

Not sure if pwsh will have hooks for the >>

This should also ensure that they are all replayed correctly (shift+enter, bracketed paste mode, different line break?)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Jan 13, 2022
@Tyriar Tyriar added this to the January 2022 milestone Jan 13, 2022
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge Jan 13, 2022
Tyriar added a commit that referenced this issue Jan 20, 2022
@Tyriar
Get multi-line pwsh command lines working
92e744d 
Part of #140665
This was referenced Jan 20, 2022
Merged
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jan 25, 2022

This is too much of a change after testing has happened, pushing to Feb.

@Tyriar Tyriar modified the milestones: January 2022, February 2022 Jan 25, 2022
Tyriar added a commit that referenced this issue Feb 18, 2022
@Tyriar
Support line continuations in bash
0ccca0d 
Part of #140665
@Tyriar Tyriar mentioned this issue Feb 18, 2022
Merged
@Tyriar Tyriar closed this as completed in 813ede9 Feb 18, 2022
@meganrogge meganrogge mentioned this issue Feb 19, 2022
Closed
3 tasks
@connor4312 connor4312 added the verified Verification succeeded label Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
4 participants
@Tyriar @connor4312 @meganrogge and others