Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments panel - discoverability feedback #143948

Closed
lszomoru opened this issue Feb 25, 2022 · 2 comments
Closed

Comments panel - discoverability feedback #143948

lszomoru opened this issue Feb 25, 2022 · 2 comments
Assignees
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

Testing #143545

This has come up during one of our stand-ups, and I fully agree that the comments on a pull request act like a "todo" list of feedback that needs to be addressed as part of the review process. We need to make the comments more discoverable.

I would like to propose that we make comments "first class items" and move them into the file list. Have you looked at the Azure Repos pull request experience, which I think that it is one of the best out there? Comments are being surfaced as part of the tree showing the files that are part of the pull request.

@alexr00 alexr00 added under-discussion Issue is under discussion for relevance, priority, approach comments Comments Provider/Widget/Panel issues labels Feb 25, 2022
@alexr00 alexr00 added this to the March 2022 milestone Feb 25, 2022
@alexr00
Copy link
Member

alexr00 commented Mar 9, 2022

I think the file list you are referencing is the "Changes in PR" view, which is contributed by the GitHub Pull Requests and Issues extension. We could put comments in that view in that extension, but that would only help one extension. I would propose 2 things instead:

  • When you open a file that has comments, show the comments panel. This will be controlled by a setting.
  • In the GHPRI extension, also show the comments panel when a PR is opened (same as how the "Changes in PR" view is shown). I will probably key this off the same setting.

@alexr00 alexr00 added the feature-request Request for new features or functionality label Mar 9, 2022
@alexr00 alexr00 closed this as completed in c0d5f3e Mar 9, 2022
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Mar 9, 2022
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Mar 9, 2022
@alexr00 alexr00 removed the under-discussion Issue is under discussion for relevance, priority, approach label Mar 9, 2022
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Mar 21, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Mar 23, 2022

/verified

@rchiodo rchiodo added the verified Verification succeeded label Mar 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@lszomoru @rchiodo @alexr00 and others