Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Rename Side Panel #145634

Closed
2 tasks done
sbatten opened this issue Mar 22, 2022 · 2 comments
Closed
2 tasks done

Test: Rename Side Panel #145634

sbatten opened this issue Mar 22, 2022 · 2 comments

Comments

@sbatten
Copy link
Member

sbatten commented Mar 22, 2022

Complexity: 3

Create Issue


When shipping the side panel, we deprecated the ability to move the bottom panel hoping to leverage view movement to solve most of the use cases. Unfortunately, this did not work as expected and instead we decided to keep the bottom panel movement. As part of this change in direction, we decided to rename the Side Panel to avoid the confusion of a side panel and a panel that moves to the left/right (to the side).

In the UX, we now refer to the 3 surfaces: Primary Side Bar, Secondary Side Bar, and Panel.

Testing

Review the editor strings to ensure we have correct presentations of these new names:

  1. Menu Bar > View > Appearance
  2. Command Palette Commands
  3. The Layout Control in the custom title bar (hovers)
  4. Customize Layout command quick pick
  5. Setting descriptions (we don't change setting titles for compatibility reasons)
  6. Right click menus of parts (e.g. Hide Primary Side Bar)
  7. Anything that comes to mind I might have overlooked.

Note Under the hood, commands are using AuxiliaryBar as a clear distinction from the other to surfaces which allowed us to change names without ties to the command name.

@miguelsolorio
Copy link
Contributor

Under the hood, commands are using AuxiliaryBar as a clear distinction from the other to surfaces which allowed us to change names without ties to the command name.

Should this get updated at some point? i know one piece of debt that lingers is the renaming of areas that have been changed over time (like the simple checkbox example @TylerLeonhardt recently renamed)

@sbatten
Copy link
Member Author

sbatten commented Mar 22, 2022

There is a separate debt item for cleanup of the code. I didn't mix this here because unlike the checkbox example, this has a direct impact on the users keybindings and I want the name to be settled before messing with that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants