Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle side bar command name consistency #145858

Closed
chrmarti opened this issue Mar 23, 2022 · 1 comment
Closed

Toggle side bar command name consistency #145858

chrmarti opened this issue Mar 23, 2022 · 1 comment
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone
March 2022

Comments

@chrmarti
Copy link
Contributor

Testing #145634

Nit: Both should have or not have 'Visibility' in their name:
image
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Mar 23, 2022
@sbatten sbatten added this to the March 2022 milestone Mar 23, 2022
@sbatten
Copy link
Member

sbatten commented Mar 24, 2022

I've opted to add Visibility to the Secondary Side Bar command AND the Toggle Panel command as well. All workbench parts had a Toggle X Visibility command aside from the panel and secondary side bar before the change. Now all do.

@rebornix rebornix added the verified Verification succeeded label Mar 24, 2022
gabritto pushed a commit to gabritto/vscode that referenced this issue Mar 25, 2022
@sbatten @gabritto
fixes microsoft#145858
fb9b1cd
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
4 participants
@rebornix @sbatten @chrmarti and others