Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar vs side bar #145863

Closed
chrmarti opened this issue Mar 23, 2022 · 3 comments
Closed

Sidebar vs side bar #145863

chrmarti opened this issue Mar 23, 2022 · 3 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone
March 2022

Comments

@chrmarti
Copy link
Contributor

Testing #145634

Found sidebar in this setting's description, everywhere else it is side bar:
image
@chrmarti
Copy link
Contributor Author

Similarly, also missing 'primary', although this view can be moved around:
image

@chrmarti
Copy link
Contributor Author

"window.menuBarVisibility" also has 'sidebar' in its description and enum description. (This setting is not available on Mac.)

@sbatten
Copy link
Member

sbatten commented Mar 23, 2022

great finds :)

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Mar 23, 2022
@sbatten sbatten added this to the March 2022 milestone Mar 23, 2022
sbatten added a commit that referenced this issue Mar 24, 2022
@sbatten
more sidebar to side bar
a3b788e 
refs #145863
sbatten added a commit that referenced this issue Mar 24, 2022
@sbatten
more sidebar to side bar
256ec34 
refs #145863
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 24, 2022
gabritto pushed a commit to gabritto/vscode that referenced this issue Mar 25, 2022
@sbatten @gabritto
sidebar to side bar
e4f2806 
fixes microsoft#145863
gabritto pushed a commit to gabritto/vscode that referenced this issue Mar 25, 2022
@sbatten @gabritto
more sidebar to side bar
07719bb 
refs microsoft#145863
gabritto pushed a commit to gabritto/vscode that referenced this issue Mar 25, 2022
@sbatten @gabritto
more sidebar to side bar
8b7382a 
refs microsoft#145863
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
4 participants
@sbatten @rzhao271 @chrmarti and others