Move command invalidation from decoration addon to command detection capability #145893
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
terminal-persistence
Relating to process reconnection or process revive
terminal-shell-integration
Shell integration, command decorations, etc.
verified
Verification succeeded
Milestone
We currently have this which runs on the renderer process only:
vscode/src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts
Lines 174 to 180 in 483ec48
What we should do instead to ensure these changes carry over across reconnects is to mark commands as invalid or something and fire an event inside the command detection capability. The decorations addon would then listen to it and react accordingly.
The text was updated successfully, but these errors were encountered: