Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decorations get out of sync when reconnecting after resize on Windows #146059

Closed
Tyriar opened this issue Mar 25, 2022 · 3 comments · Fixed by #150050
Closed

Decorations get out of sync when reconnecting after resize on Windows #146059

Tyriar opened this issue Mar 25, 2022 · 3 comments · Fixed by #150050
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded windows VS Code on Windows issues
Milestone
May 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 25, 2022

Repro on Windows:

  1. Run some commands
  2. Increase the height of the terminal
  3. Detach the terminal
  4. Attach to it again

Recording 2022-03-25 at 07 44 41
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues terminal-shell-integration Shell integration, command decorations, etc. labels Mar 25, 2022
@Tyriar Tyriar added this to the April 2022 milestone Mar 25, 2022
@meganrogge meganrogge modified the milestones: April 2022, May 2022 Apr 25, 2022
@meganrogge meganrogge removed their assignment May 2, 2022
@Tyriar
Copy link
Member Author

Tyriar commented May 4, 2022 •
edited

This will probably be fixed by #145893

@Tyriar
Copy link
Member Author

Tyriar commented May 20, 2022

Seems to be happening because the resized lines that get deleted upon resize are getting restored (but duplicating the lines that move up):

image

@Tyriar
Copy link
Member Author

Tyriar commented May 20, 2022

Oh a resize adjustment happens upon replaying old events, that seems wrong

image

@Tyriar Tyriar mentioned this issue May 20, 2022
Closed
Tyriar added a commit that referenced this issue May 20, 2022
@Tyriar
Use correct terminal dimensions when restoring a terminal
900b870 
Fixes #146059
@Tyriar Tyriar mentioned this issue May 20, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 20, 2022
@Tyriar Tyriar added the verified Verification succeeded label Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Use correct terminal dimensions when restoring a terminal microsoft/vscode
3 participants
@Tyriar @meganrogge @VSCodeTriageBot