Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peek references doesn't reveal peek #147448

Closed
jrieken opened this issue Apr 14, 2022 · 4 comments
Closed

Peek references doesn't reveal peek #147448

jrieken opened this issue Apr 14, 2022 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Apr 14, 2022

  • invoke peek references for a symbol at the bottom the view port
  • 🐛 no scrolling, peek is barely visible
Screen.Recording.2022-04-14.at.14.01.36.mov
@jrieken jrieken self-assigned this Apr 14, 2022
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug editor-symbols definitions, declarations, references labels Apr 14, 2022
@jrieken jrieken added this to the April 2022 milestone Apr 14, 2022
jrieken added a commit that referenced this issue Apr 14, 2022
@jrieken
Copy link
Member Author

jrieken commented Apr 14, 2022

@alexdima @hediet I could only achieve this with an ugly setTimeout, e.g calling "reveal" after "super.show(...)" has no effect. Is it that the view zone is created async and that at the time of calling reveal the knowledge about that isn't there yet?

@jrieken
Copy link
Member Author

jrieken commented Apr 25, 2022

ping @hediet @alexdima

@alexdima
Copy link
Member

@jrieken (without debugging) I guess that super.show(...) is the call that adds the view zone. So in this case the revealRangeInCenterIfOutsideViewport call done before super.show(...) is probably a no-op because the range that is passed in is already in the viewport, so it will not be revealed in the center, as the method name hints.

@jrieken
Copy link
Member Author

jrieken commented Apr 26, 2022

@alexdima it doesn't matter if the reveal-call happens before or after - it won't work either way. Also running with next microtask or animation frame didn't work, only setTimeout...

@alexdima alexdima self-assigned this Apr 27, 2022
@alexdima alexdima added editor-rendering Editor rendering issues and removed editor-symbols definitions, declarations, references labels Apr 28, 2022
@amunger amunger added the verified Verification succeeded label Apr 29, 2022
aeschli pushed a commit that referenced this issue May 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@jrieken @amunger @alexdima and others