Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified Elsewhere aria label should be more concise #153588

Closed
isidorn opened this issue Jun 28, 2022 · 0 comments · Fixed by #153625
Closed

Modified Elsewhere aria label should be more concise #153588

isidorn opened this issue Jun 28, 2022 · 0 comments · Fixed by #153625
Assignees
@rzhao271
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
June 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2022

Testing #153351

Currently the screen reader reads out "The default value of the setting has also been overridden for the following languages: LANG1, LANG2".

We should always strive towards concisnes for aria labels. So let's go with something like:
"LANG1, LANG2... have overridden this setting"

Similar for other cases. Just try to keep the label as concise as possible :)
@rzhao271 rzhao271 added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 28, 2022
@rzhao271 rzhao271 added this to the June 2022 milestone Jun 28, 2022
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jun 28, 2022
@rzhao271 rzhao271 mentioned this issue Jun 28, 2022
Merged
rzhao271 added a commit that referenced this issue Jun 29, 2022
@rzhao271
Shorten Settings editor aria labels (#153625)
0a45975 
Fixes #153588
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 29, 2022
@isidorn isidorn added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Shorten Settings editor aria labels microsoft/vscode
3 participants
@isidorn @rzhao271 @VSCodeTriageBot